[18.0][FIX] l10n_eu_product_adr: restore label pictograms - #292
Open
rrebollo wants to merge 1 commit into
Open
Conversation
CSV cannot express type="base64" file="...", so data/adr.label.csv left image empty for all 22 labels and static/img/*.svg unreferenced. image is required=True and rendered in form/kanban. Keep data/adr_label.xml as XML (only 22 records) to preserve file= construct. Mirrors 19.0 fix fae7bcd (PR OCA#290). On existing DBs noupdate="1" prevents auto-backfill on -u; re-init with --init=l10n_eu_product_adr or manual reload restores images (see bosd comment).
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We introduced this error in #241 ([18.0][IMP] l10n_eu_product_adr: migrate xml data files to csv) when migrating data files from XML to CSV.
data/adr.label.csvcannot carrytype="base64" file="...", so all 22adr.label.image(required) shipped empty andstatic/img/ADR_*.svgwere orphaned — pictograms missing in form/kanban (see #290 (comment)).This PR corrects it by restoring
data/adr_label.xml(22 records withtype="base64" file="l10n_eu_product_adr/static/img/ADR_*.svg") and updating__manifest__.py(CSV → XML).@BinhexTeam T12289