[18.0] Add edi_party_helper_oca, deprecate edi_party_data_oca - #330
Open
simahawk wants to merge 3 commits into
Open
[18.0] Add edi_party_helper_oca, deprecate edi_party_data_oca#330simahawk wants to merge 3 commits into
simahawk wants to merge 3 commits into
Conversation
OCA-git-bot
added
series:18.0
mod:edi_party_data_oca
Contributor
Author
|
test fails only on license check |
SilvioC2C
approved these changes
Aug 27, 2026
SilvioC2C
left a comment
SilvioC2C
left a comment
Contributor
There was a problem hiding this comment.
Overall LGTM, a couple of minor remarks
Comment on lines
+14
to
+15
| "auto_install": True, | ||
| "post_init_hook": "post_init_hook", |
Contributor
There was a problem hiding this comment.
Two things:
- since the module is getting deprecated, shouldn't it make sense to remove the
auto_installflag? post_init_hookis only executed upon module installation: would it make sense to add apost_loadhook too to display the deprecation warning whenever the module is loaded?
Contributor
Author
There was a problem hiding this comment.
very good points. In fact I wanted to use post_load but I forgot about it 😓
And for the auto_install flag: correct! I'll fix them thanks!
simahawk
force-pushed
the
18-edi-party-ref
branch
from
August 27, 2026 13:52
9cd4853 to
21c280d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extract EDI party-data lookup out of the
componentframework so it can be used standalone.edi_party_helper_oca:EDIParty, a plain dataclass (nocomponentdependency) that computes party data (name,identifiers,endpoint,lang) and behaves like a read-only dict for backward compat. Exposed via a newedi.party.helperabstract model (get_party(exchange_record, partner, **kw)). Moved theid_category_idsfield/view here too.edi_party_data_oca:edi.party.data.mixincomponent now just delegates toedi.party.helper, kept only for backward compatibility.edi_party_data_ocaandedi_exchange_template_party_datamarked deprecated: readme notes + apost_init_hooklogging a deprecation message on install.edi_party_helper_oca, component tests trimmed to wiring-only checks.