[18.0][IMP] purchase_exception: Use hook to popup exception after rollback - #3012
Open
grindtildeath wants to merge 4 commits into
Open
[18.0][IMP] purchase_exception: Use hook to popup exception after rollback#3012grindtildeath wants to merge 4 commits into
grindtildeath wants to merge 4 commits into
Conversation
2 tasks
grindtildeath
changed the title
OCA-git-bot
added
series:18.0
mod:purchase_exception
grindtildeath
force-pushed
the
18.0-imp-purchase_exception_rollback_popup
branch
from
May 27, 2026 20:34
d4cb26e to
79f0c6d
Compare
OCA-git-bot
added
the
mod:purchase_order_approval_block
grindtildeath
force-pushed
the
18.0-imp-purchase_exception_rollback_popup
branch
from
May 27, 2026 21:06
c2b5c30 to
e3815f5
Compare
wouitmil
approved these changes
May 28, 2026
SilvioC2C
approved these changes
May 28, 2026
vvrossem
approved these changes
May 29, 2026
divad1196
approved these changes
May 29, 2026
divad1196
left a comment
divad1196
left a comment
There was a problem hiding this comment.
Except for button_to_approve where it looks like a function is missing, the rest looks good. Good work
1 task
BhaveshHeliconia
approved these changes
Jun 25, 2026
With OCA/server-tools#3590 changing the way exceptions are detected, the error raising doesn't allow to call _popup_exception as we used to, but we can use the new hook to have the popup displayed smoothly.
…ollback With OCA/server-tools#3590 changing the way exceptions are detected, the error raising doesn't allow to call _popup_exception as we used to, but we can use the new hook to have the popup displayed smoothly.
With OCA/server-tools#3590 changing the way exceptions are detected and rollbacked, tests need to be adapted accordingly.
grindtildeath
force-pushed
the
18.0-imp-purchase_exception_rollback_popup
branch
from
September 3, 2026 19:43
f7dfbba to
8f6e3f2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With OCA/server-tools#3590 changing the way exceptions are detected, the error raising doesn't allow to call
_popup_exceptionas we used to, but we can use the new hook to have the popup displayed smoothly.Depends on: