[16.0][ADD] purchase_deposit_company_amount - #3161
Open
AungKoKoLin1997 wants to merge 1 commit into
Open
Conversation
AungKoKoLin1997
marked this pull request as draft
September 1, 2026 09:54
AungKoKoLin1997
force-pushed
the
16.0-add-purchase_deposit_company_amount
branch
2 times, most recently
from
September 1, 2026 10:15
7cbde9a to
d4fc3db
Compare
AungKoKoLin1997
marked this pull request as ready for review
September 1, 2026 10:15
yostashiro
reviewed
Sep 1, 2026
AungKoKoLin1997
force-pushed
the
16.0-add-purchase_deposit_company_amount
branch
2 times, most recently
from
September 2, 2026 03:31
36ad8d5 to
97c10f0
Compare
AungKoKoLin1997
force-pushed
the
16.0-add-purchase_deposit_company_amount
branch
from
September 2, 2026 03:43
97c10f0 to
4185fbe
Compare
yostashiro
approved these changes
Sep 2, 2026
yostashiro
left a comment
Member
There was a problem hiding this comment.
Code review and functional test. LGTM. 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This module books a foreign-currency purchase deposit at the company-currency amount actually paid and carries that figure through to the final bill, so the deposit account clears to zero and the exchange-rate difference lands in the inventory cost of the goods instead of being stranded on the balance sheet.
In detail:
bill, which forces the line's balance to the amount entered instead
of converting the foreign currency amount at the exchange rate.
the deposit offset line of the final bill, so the deposit account
closes out at the amount that was actually paid.
and reflects it in the stock valuation of the received goods.
The field is only available on the deposit line of a deposit bill raised in a foreign currency, and the column is hidden everywhere else. Everything on the final bill is derived from it, and a deposit nobody entered an amount for keeps the standard rate conversion throughout.
@qrtl QT6131