[18.0][IMP] rma: Add delivered_qty_done + remaining_qty_to_done - #623 - #624
Merged
OCA-git-bot merged 1 commit intoSep 3, 2026
Merged
Conversation
The fields were unnecessarily removed in OCA@9cc5bca but already existed in v16 The _compute_delivered_qty_done() method was added because the _compute_delivered_qty() method could not be used with compute_sudo (inconsistent across fields) and the same method could not be used for fields with store=True and store=False Fixes OCA#615 Co-authored-by: Biel Vidal <biel.vidal@netkia.es>
Contributor
|
Hi @pedrobaeza, @chienandalu, |
pedrobaeza
approved these changes
Sep 3, 2026
pedrobaeza
left a comment
pedrobaeza
left a comment
Member
There was a problem hiding this comment.
Code review comparing previous branches.
Member
|
/ocabot merge minor |
Contributor
|
This PR looks fantastic, let's merge it! |
Contributor
|
@victoralmau @pedrobaeza Thanks for your help |
Contributor
|
Congratulations, your PR was merged at c35d593. Thanks a lot for contributing to OCA. ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FWP from 17.0: #623
Add
delivered_qty_done+remaining_qty_to_doneThe fields were unnecessarily removed in 9cc5bca but already existed in v16
The
_compute_delivered_qty_done()method was added because the_compute_delivered_qty()method could not be used with compute_sudo (inconsistent across fields) and the same method could not be used for fields with store=True and store=FalseFixes #615
Please @pedrobaeza and @carlos-lopez-tecnativa can you review it?
@Tecnativa