Skip to content

[18.0][IMP] auth_oidc_environment: extra fields - #922

Open
qgroulard wants to merge 1 commit into
OCA:18.0from
acsone:18.0-auth_oidc_environment_extra_fields-qgr
Open

[18.0][IMP] auth_oidc_environment: extra fields#922
qgroulard wants to merge 1 commit into
OCA:18.0from
acsone:18.0-auth_oidc_environment_extra_fields-qgr

Conversation

@qgroulard

@qgroulard qgroulard commented Apr 1, 2026

Copy link
Copy Markdown
Contributor

Needs OCA/server-env#264

I believe more fields make sense to be configurable by environment.

Typically when you use different SSO for test and production.

@sbidoul sbidoul left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this need a migration or will it preserve existing values when this is deployed without setting the new env options?

@qgroulard

Copy link
Copy Markdown
Contributor Author

Does this need a migration or will it preserve existing values when this is deployed without setting the new env options?

AFAIK no migration script is needed, this does nothing while no env var is set.

@sbidoul

sbidoul commented Apr 2, 2026

Copy link
Copy Markdown
Member

I had the impression that server_environment removes the colums from the database and gets the data from a json field, but I don't know how it works when you add already-used fields to the server env mixin.

@qgroulard

Copy link
Copy Markdown
Contributor Author

I'll try to have a look but if this is the case we might have problems here as well: OCA/server-env@3574e86

@qgroulard

Copy link
Copy Markdown
Contributor Author

Good catch, the previous values are indeed ignored.

I have opened this PR: OCA/server-env#264

@qgroulard
qgroulard force-pushed the 18.0-auth_oidc_environment_extra_fields-qgr branch from 1ae5441 to 0f8a6e6 Compare April 2, 2026 13:43
Comment thread auth_oidc_environment/__manifest__.py Outdated
"depends": [
"auth_oidc",
"server_environment",
"server_environment>18.0.1.0.6",

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sbidoul pre-commit doesn't like that. What would be the right syntax ?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yes, Odoo would not support that either.

So the trick is to do that with a new section in pyproject.toml:

[tool.whool]
depends_override = { "server_environment": "odoo-addon-server_environment ==18.0.*, >18.0.1.0.6" }

@github-actions

Copy link
Copy Markdown

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions Bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Aug 23, 2026
@qgroulard
qgroulard force-pushed the 18.0-auth_oidc_environment_extra_fields-qgr branch from 0f8a6e6 to e3daaf1 Compare August 24, 2026 07:06
@OCA-git-bot OCA-git-bot added series:18.0 mod:auth_oidc_environment Module auth_oidc_environment labels Aug 24, 2026
@qgroulard
qgroulard force-pushed the 18.0-auth_oidc_environment_extra_fields-qgr branch from e3daaf1 to 8068c8c Compare August 24, 2026 07:13
@github-actions github-actions Bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Aug 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

mod:auth_oidc_environment Module auth_oidc_environment series:18.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants