[18.0][FIX] vault: show clear message on wrong unlock password - #988
Open
jans23 wants to merge 1 commit into
Open
[18.0][FIX] vault: show clear message on wrong unlock password#988jans23 wants to merge 1 commit into
jans23 wants to merge 1 commit into
Conversation
jans23
force-pushed
the
18.0-fix-vault-wrong-password-message
branch
from
August 24, 2026 12:35
a691487 to
a036233
Compare
fkantelberg
suggested changes
Sep 2, 2026
| } catch { | ||
| throw new Error( | ||
| _t("The entered password is wrong. Please try again.") | ||
| ); |
Member
There was a problem hiding this comment.
The original message should atleast be written to console.error(...)
Contributor
Author
There was a problem hiding this comment.
changed as requested.
| this.keys = { | ||
| publicKey: await vault_utils.load_public_key(params.public), | ||
| privateKey: await vault_utils.load_private_key( | ||
| let privateKey = null; |
Member
There was a problem hiding this comment.
Everything else is using snake_case. Please stick to it for consistency.
Contributor
Author
There was a problem hiding this comment.
changed as requested.
Raise a clear message instead of raw OperationError when entering a wrong password.
jans23
force-pushed
the
18.0-fix-vault-wrong-password-message
branch
from
September 2, 2026 12:05
a036233 to
910ed44
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Raise a clear message instead of raw OperationError when entering a wrong password.