Skip to content

[19.0][MIG] base_kanban_stage - #3473

Open
JasminSForgeFlow wants to merge 30 commits into
OCA:19.0from
ForgeFlow:19.0-mig-base_kanban_stage
Open

[19.0][MIG] base_kanban_stage#3473
JasminSForgeFlow wants to merge 30 commits into
OCA:19.0from
ForgeFlow:19.0-mig-base_kanban_stage

Conversation

@JasminSForgeFlow

Copy link
Copy Markdown
Contributor

Standard Migration

  • Refactor test for creation of temporary model

@ForgeFlow

@AaronHForgeFlow AaronHForgeFlow left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional ok. 👍 Tested with another module that depends on this one.

@AaronHForgeFlow

Copy link
Copy Markdown
Contributor

Error in the tests are not really errors, it is something in the readme, a check that should not be failing IMHO:

`Error: Errors detected in log.

errors that caused failure (2):
2025-12-22 08:18:00,880 308 WARNING odoo odoo.addons.base.models.ir_module: docutils' system message present: <system_message level="2" line="31" source="" type="WARNING">Cannot analyze code. Pygments package not found.<literal_block xml:space="preserve">.. code-block:: python

class MyModel(models.Model):
_name = 'my.model'
_inherit = 'base.kanban.abstract'
</literal_block></system_message>
2025-12-22 08:18:00,880 308 WARNING odoo odoo.addons.base.models.ir_module: docutils' system message present: <system_message level="2" line="44" source="" type="WARNING">Cannot analyze code. Pygments package not found.<literal_block xml:space="preserve">.. code-block:: xml

My Model - Kanban View my.model primary `

@JasminSForgeFlow
JasminSForgeFlow force-pushed the 19.0-mig-base_kanban_stage branch from 11de8d0 to 5bf416a Compare December 22, 2025 09:21
@AaronHForgeFlow

Copy link
Copy Markdown
Contributor

@JasminSForgeFlow can you check failed CIs?

Ted Salmon and others added 5 commits August 17, 2026 10:29
* Add Kanban-compatible stage model base.kanban.stage
* Add views, menu items, actions, and access controls needed to manage base.kanban.stage records
* Add abstract model base.kanban.abstract that other models can inherit from to gain Kanban stage functionality
* Add base Kanban view base_kanban_abstract_view_kanban, which can be customized as needed for use with models that inherit from base.kanban.abstract
* Add model base.kanban.abstract.tester, which is needed for base.kanban.abstract unit tests
* Rename manifest
* Change openerp references to odoo
* Bump version
* Update depends to `base`
* Update priority selections to match Odoo guidelines
* Update comment block to triple double quotes
* Update `kanban_user_id` to `user_id` in code and view
* Update README to incorporate use of mode in example view
* Add group_expand attr to abstract kanban model, allowing for empty columns
* Fix `_read_group_stage_ids` for new API
@JasminSForgeFlow
JasminSForgeFlow force-pushed the 19.0-mig-base_kanban_stage branch from 5bf416a to 5f0f0fb Compare August 17, 2026 04:59
@JasminSForgeFlow

Copy link
Copy Markdown
Contributor Author

@JasminSForgeFlow can you check failed CIs?

its good now

@AaronHForgeFlow AaronHForgeFlow left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional 👍

Comment on lines +19 to +21
_group_by_full = {
"stage_id": lambda s, *a, **k: s._read_group_stage_ids(*a, **k),
}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
_group_by_full = {
"stage_id": lambda s, *a, **k: s._read_group_stage_ids(*a, **k),
}

_group_by_full was deprecated in favor of declaring group_expand= directly on the field. This model already has group_expand="_read_group_stage_ids" on stage_id, so the dict is now redundant and can be safely removed.

<a
role="button"
class="dropdown-toggle o-no-caret btn"
data-toggle="dropdown"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
data-toggle="dropdown"
data-bs-toggle="dropdown"

t-att-alt="record.user_id.value"
width="24"
height="24"
class="oe_kanban_avatar float-right"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
class="oe_kanban_avatar float-right"
class="oe_kanban_avatar float-end"

@BhaveshHeliconia

Copy link
Copy Markdown
Contributor

And could you please squash the administrative and bot commits?

@JasminSForgeFlow
JasminSForgeFlow force-pushed the 19.0-mig-base_kanban_stage branch from 5f0f0fb to f3eb608 Compare September 1, 2026 06:19
@JasminSForgeFlow

Copy link
Copy Markdown
Contributor Author

@BhaveshHeliconia, changes have been made; please check it.

Thanks.

@BhaveshHeliconia BhaveshHeliconia left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JasminSForgeFlow you should only merge translation commits coming from the same author, not all the translations commits together.
https://github.com/OCA/maintainer-tools/wiki/Merge-commits-in-pull-requests#mergesquash-the-commits-generated-by-bots-or-weblate

lasley and others added 11 commits September 1, 2026 12:41
…stract_view_kanban; user_id instead of kanban_user_id
* Add default stage_id logic that returns lowest sequence stage associated with
inheriting model and update unit tests accordingly
* Improve _read_group_stage_ids unit test
* Implement latest abstract model testing strategy
(Two fields (kanban_color, color) of project.project() have the same label: Color Index.)
Signed-off-by: Luis Felipe Mileo <mileo@kmee.com.br>
mileo and others added 14 commits September 1, 2026 12:41
Signed-off-by: Luis Felipe Mileo <mileo@kmee.com.br>
Currently translated at 16.6% (10 of 60 strings)

Translation: server-tools-14.0/server-tools-14.0-base_kanban_stage
Translate-URL: https://translation.odoo-community.org/projects/server-tools-14-0/server-tools-14-0-base_kanban_stage/it/
Currently translated at 100.0% (60 of 60 strings)

Translation: server-tools-14.0/server-tools-14.0-base_kanban_stage
Translate-URL: https://translation.odoo-community.org/projects/server-tools-14-0/server-tools-14-0-base_kanban_stage/es_AR/
Currently translated at 16.6% (10 of 60 strings)

Translation: server-tools-15.0/server-tools-15.0-base_kanban_stage
Translate-URL: https://translation.odoo-community.org/projects/server-tools-15-0/server-tools-15-0-base_kanban_stage/it/
Currently translated at 16.6% (10 of 60 strings)

Translation: server-tools-15.0/server-tools-15.0-base_kanban_stage
Translate-URL: https://translation.odoo-community.org/projects/server-tools-15-0/server-tools-15-0-base_kanban_stage/it/
Currently translated at 100.0% (60 of 60 strings)

Translation: server-tools-15.0/server-tools-15.0-base_kanban_stage
Translate-URL: https://translation.odoo-community.org/projects/server-tools-15-0/server-tools-15-0-base_kanban_stage/es/
@JasminSForgeFlow
JasminSForgeFlow force-pushed the 19.0-mig-base_kanban_stage branch from f3eb608 to 797f729 Compare September 1, 2026 07:16
@JasminSForgeFlow

Copy link
Copy Markdown
Contributor Author

you should only merge translation commits coming from the same author, not all the translations commits together.
https://github.com/OCA/maintainer-tools/wiki/Merge-commits-in-pull-requests#mergesquash-the-commits-generated-by-bots-or-weblate

Done

@OCA-git-bot

Copy link
Copy Markdown
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.