[FIX] bus_alt_connection: wrong configuration key in documentation - #3721
Open
leemannd wants to merge 1 commit into
Open
[FIX] bus_alt_connection: wrong configuration key in documentation#3721leemannd wants to merge 1 commit into
leemannd wants to merge 1 commit into
Conversation
Into the code it checks for a prefix like ODOO_IMDISPATCHER_DB_ See: https://github.com/OCA/server-tools/blob/18.0/bus_alt_connection/models/bus.py#L24C32-L24C53
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Into the code it checks for a prefix like ODOO_IMDISPATCHER_DB_ See: https://github.com/OCA/server-tools/blob/18.0/bus_alt_connection/models/bus.py#L24C32-L24C53
I am currently wondering why we have distinct values given if the configuration is done in config or environment:
os.environ.get(f"ODOO_IMDISPATCHER_DB_{p.upper()}")VSconfig.get("imdispatcher_db_" + p)Wouldn't it be better to have these using the same base name?