Skip to content

[18.0] [IMP] storage: Remove dependency on server_environment - #655

Open
yankinmax wants to merge 34 commits into
OCA:18.0from
camptocamp:18-storage-split
Open

[18.0] [IMP] storage: Remove dependency on server_environment#655
yankinmax wants to merge 34 commits into
OCA:18.0from
camptocamp:18-storage-split

Conversation

@yankinmax

@yankinmax yankinmax commented Aug 20, 2026

Copy link
Copy Markdown

@OCA-git-bot

OCA-git-bot commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

Hi @lmignon,
some modules you are maintaining are being modified, check this out!

@OCA-git-bot OCA-git-bot added mod:fs_folder Module fs_folder mod:fs_storage Module fs_storage mod:fs_attachment Module fs_attachment series:18.0 mod:storage_backend_s3 Module storage_backend_s3 mod:fs_attachment_s3 Module fs_attachment_s3 mod:storage_file Module storage_file mod:fs_storage_environment Module fs_storage_environment mod:fs_attachment_s3_environment Module fs_attachment_s3_environment mod:fs_attachment_environment Module fs_attachment_environment mod:storage_backend Module storage_backend mod:storage_backend_sftp Module storage_backend_sftp mod:storage_backend_ftp Module storage_backend_ftp mod:storage_backend_environment Module storage_backend_environment mod:storage_backend_sftp_environment Module storage_backend_sftp_environment mod:storage_backend_s3_environment Module storage_backend_s3_environment mod:storage_file_environment Module storage_file_environment mod:fs_folder_environment Module fs_folder_environment mod:storage_backend_ftp_environment Module storage_backend_ftp_environment labels Aug 20, 2026
@yankinmax

yankinmax commented Aug 20, 2026

Copy link
Copy Markdown
Author

Hello @etobella @lmignon @ivantodorovich
In this PR I've cherry-picked the commits from 17.0 PR:

lmignon
lmignon requested changes Aug 20, 2026
View reviewed changes

@lmignon lmignon left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the FWP/ Unfortunately, tests are failing.

@yankinmax

yankinmax commented Aug 20, 2026

Copy link
Copy Markdown
Author

Thank you for the FWP/ Unfortunately, tests are failing.

I'm on it. As it's a big one, so I've decided to inform you about the work.
I'll double ping when tests are fixed

@yankinmax yankinmax mentioned this pull request Aug 20, 2026
Open
1 task
@yankinmax
yankinmax force-pushed the 18-storage-split branch 2 times, most recently from f4de43f to 38c79d3 Compare August 20, 2026 13:51
@yankinmax yankinmax mentioned this pull request Aug 20, 2026
Merged
@lmignon

lmignon commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

@yankinmax Where are the commits fixing the tests?

@yankinmax

yankinmax commented Aug 20, 2026 via email

Copy link
Copy Markdown
Author

@yankinmax
[ADD] storage_backend_sftp_environment
8e3c00e
@yankinmax
[FIX] storage_backend_sftp: Add migration script for server_environme…
deb8c9f 
…nt split
@yankinmax
[IMP] storage_backend_sftp_environment: preserve data on install and …
b43e94d 
…restore columns on uninstall
@yankinmax
[IMP] fs_folder: Remove environment data
5fbf123
@yankinmax
[ADD] fs_folder_environment
ce25762
@yankinmax
[FIX] fs_folder: Add migration script for server_environment split
e1c64fa
@yankinmax
[IMP] fs_folder_environment: preserve data on install and restore col…
4129375 
…umns on uninstall
@yankinmax
[IMP] storage_backend_ftp: Remove environment data
81207e5
@yankinmax
[ADD] storage_backend_ftp_environment
22611ff
@yankinmax
[FIX] storage_backend_ftp: Add migration script for server_environmen…
43f15c8 
…t split
@yankinmax
[IMP] storage_backend_ftp_environment: preserve data on install and r…
0e35a2b 
…estore columns on uninstall
@yankinmax
[IMP] storage_backend_s3: Remove environment data
243bcb5
@yankinmax
[ADD] storage_backend_s3_environment
5f7e753
@yankinmax
[FIX] storage_backend_s3: Add migration script for server_environment…
2e2640b 
… split
@yankinmax
[IMP] storage_backend_s3_environment: preserve data on install and re…
eb62422 
…store columns on uninstall
@yankinmax
[IMP] storage_file: Remove environment data
c32d15a
@yankinmax
[ADD] storage_file_environment
fedf9b7
@yankinmax
[FIX] storage_file: Add migration script for server_environment split
43f5812
@yankinmax
[IMP] storage_file_environment: preserve data on install and restore …
4887db5 
…columns on uninstall
@yankinmax

yankinmax commented Sep 2, 2026

Copy link
Copy Markdown
Author

Hello @etobella @simahawk @sbidoul can you pls also approve this one forward ported from v17 and trigger merge?

@lmignon

lmignon commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

/ocabot merge nobump

@OCA-git-bot

OCA-git-bot commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

On my way to merge this fine PR!
Prepared branch 18.0-ocabot-merge-pr-655-by-lmignon-bump-nobump, awaiting test results.

@OCA-git-bot

OCA-git-bot commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

@lmignon The merge process could not be finalized, because command twine upload --disable-progress-bar --non-interactive --repository-url https://upload.pypi.org/legacy/ -u __token__ odoo_addon_storage_backend_s3_environment-18.0.1.0.0.3-py3-none-any.whl failed with output:

Uploading distributions to https://upload.pypi.org/legacy/
Uploading 
odoo_addon_storage_backend_s3_environment-18.0.1.0.0.3-py3-none-any.whl
�[33mWARNING �[0m Error during upload. Retry with the --verbose option for more details. 
�[31mERROR   �[0m HTTPError: 429 Too Many Requests from https://upload.pypi.org/legacy/  
         Too Many Requests

@simahawk

simahawk commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

@yankinmax I'm testing this split on webservice_server_env and I'm not sure that installing the module in the upgrade is enough.
@lmignon wait to merge pls, I need to test further.

@lmignon

lmignon commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

@yankinmax I'm testing this split on webservice_server_env and I'm not sure that installing the module in the upgrade is enough. @lmignon wait to merge pls, I need to test further

On Odoo 16.0 everything worked smoothly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lmignon lmignon lmignon approved these changes
@etobella etobella etobella approved these changes
+1 more reviewer
@ivantodorovich ivantodorovich ivantodorovich approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved mod:fs_attachment_environment Module fs_attachment_environment mod:fs_attachment_s3_environment Module fs_attachment_s3_environment mod:fs_attachment_s3 Module fs_attachment_s3 mod:fs_attachment Module fs_attachment mod:fs_folder_environment Module fs_folder_environment mod:fs_folder Module fs_folder mod:fs_storage_environment Module fs_storage_environment mod:fs_storage Module fs_storage mod:storage_backend_environment Module storage_backend_environment mod:storage_backend_ftp_environment Module storage_backend_ftp_environment mod:storage_backend_ftp Module storage_backend_ftp mod:storage_backend_s3_environment Module storage_backend_s3_environment mod:storage_backend_s3 Module storage_backend_s3 mod:storage_backend_sftp_environment Module storage_backend_sftp_environment mod:storage_backend_sftp Module storage_backend_sftp mod:storage_backend Module storage_backend mod:storage_file_environment Module storage_file_environment mod:storage_file Module storage_file ready to merge series:18.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@yankinmax @OCA-git-bot @lmignon @simahawk @ivantodorovich @etobella