Repository navigation
fix(docker): download mc from its GitHub release, MinIO withdrew dl.min.io and its images - #41
Merged
rpignolet merged 1 commit intoOct 2, 2026
Conversation
…in.io and its images
Contributor
Author
|
Merge order: independent of the seaweedfs chain (OKDP/helm-charts-utilities#38, then OKDP/sandbox-dependencies#46), can go any time. |
abir-oumghar
marked this pull request as ready for review
September 28, 2026 14:24
jpmewenemesse
approved these changes
Sep 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
docker/Dockerfilecopied themcclient from thequay.io/minio/mcimage since #39. MinIO closed its quay.io repositories on 2026-09-22, so the image cannot be rebuilt: theFROM quay.io/minio/mcstage fails with 401. The publishedquay.io/okdp/okdp-examples:1.2.0still works.The signed binaries are still attached to the GitHub releases of the archived
minio/mcrepository, with their checksums. The Dockerfile goes back to a plain download, from that release instead of dl.min.io, verifies the published sha256 and picks thelinux-${TARGETARCH}asset so the image builds on amd64 and arm64. The example scripts are untouched.Related Issue
Fixes #40
Type of Change
How to Test
docker build -f docker/Dockerfile -t okdp-examples-test .from the repository root completes (onmainit fails at the quay.io stage with 401).docker run --rm --entrypoint sh okdp-examples-test -c 'mc --version; trino --version; python --version'printsmc version RELEASE.2025-08-13T08-35-41Z (commit-id=7394ce0dd2a80935aded936b09fa12cbb3cb8096),Trino CLI 480andPython 3.12.x.Done locally on arm64; the CI build covers amd64.
Checklist