v1.9.0 prep - #28
Merged
Merged
Conversation
…gs API - Added pagination support to `Mappings.get()` and `AsyncMappings.get()` methods, allowing for retrieval of mappings across multiple pages. - Introduced `Mappings.get_iter()` and `AsyncMappings.get_iter()` methods to iterate through all mappings for a concept, handling pagination seamlessly. - Updated tests to verify pagination functionality and ensure correct behavior of new methods.
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
All reported issues were addressed across 3 files
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
…ter handling - Fixed the `include_invalid` parameter in `Mappings.get()` and `AsyncMappings.get()` methods to correctly reach the server when set to `False`, allowing for proper exclusion of deprecated mappings. - Updated the parameter type to `bool | None` and modified documentation to clarify its behavior. - Added unit tests to verify the correct handling of the `include_invalid` parameter in various scenarios.
There was a problem hiding this comment.
1 issue found across 3 files (changes from recent commits).
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="CHANGELOG.md">
<violation number="1" location="CHANGELOG.md:30">
P3: The new Fixed entry ends with a truncated, grammatically incomplete sentence: "Omitting it behaves exactly as before, so only callers who explicitly passed `False` - and were being ignored." The clause after "so" ("only callers who explicitly passed `False`") is never completed, so the sentence trails off with a dangling dash rather than stating the intended conclusion (that the change only affects callers who explicitly passed `False` and were previously being ignored). Please complete the sentence so the release note reads cleanly.</violation>
</file>
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
| truthy, and this endpoint defaults to *including* deprecated mappings, so | ||
| asking to exclude them did nothing. It is now `bool | None`: omit it for the | ||
| server default, pass `False` to exclude. Omitting it behaves exactly as | ||
| before, so only callers who explicitly passed `False` - and were being |
There was a problem hiding this comment.
P3: The new Fixed entry ends with a truncated, grammatically incomplete sentence: "Omitting it behaves exactly as before, so only callers who explicitly passed False - and were being ignored." The clause after "so" ("only callers who explicitly passed False") is never completed, so the sentence trails off with a dangling dash rather than stating the intended conclusion (that the change only affects callers who explicitly passed False and were previously being ignored). Please complete the sentence so the release note reads cleanly.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At CHANGELOG.md, line 30:
<comment>The new Fixed entry ends with a truncated, grammatically incomplete sentence: "Omitting it behaves exactly as before, so only callers who explicitly passed `False` - and were being ignored." The clause after "so" ("only callers who explicitly passed `False`") is never completed, so the sentence trails off with a dangling dash rather than stating the intended conclusion (that the change only affects callers who explicitly passed `False` and were previously being ignored). Please complete the sentence so the release note reads cleanly.</comment>
<file context>
@@ -20,6 +20,16 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
+ truthy, and this endpoint defaults to *including* deprecated mappings, so
+ asking to exclude them did nothing. It is now `bool | None`: omit it for the
+ server default, pass `False` to exclude. Omitting it behaves exactly as
+ before, so only callers who explicitly passed `False` - and were being
+ ignored.
+
</file context>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by cubic
Add pagination to concept mappings and add iterators to fetch all pages. Also fix
include_invalidsoFalseis sent to the server, preventing unwanted deprecated mappings.New Features
Mappings.get()andAsyncMappings.get()now acceptpageandpage_size(default 1/100). Defaults preserve prior results.Mappings.get_iter()andAsyncMappings.get_iter()to yield mappings across all pages.Bug Fixes
include_invalidis nowbool | Noneand is sent whenFalse, allowing proper exclusion of deprecated mappings in both sync and async. Tests cover tri-state behavior.Written for commit d7eb532. Summary will update on new commits.