Repository navigation
Conversation
2 of 4 tasks
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://osc.github.io/ood-documentation-test/vnc-template-options/reference/files/submit-yml/vnc-bc-options.html
Documents three VNC batch connect options on the VNC options page:
vncserver_cmdandvncpasswd_cmd, added in pinvncserverandvncpasswdto paths and addsvnctests ood_core#1006. Sites can pinvncserverandvncpasswdto full paths, or setVNCSERVER_CMD/VNCPASSWD_CMD. The page notes that the variables have to be set before the VNC server starts (script_wrapperorjob_environment), and thatbefore.shis too late. These options apply to thevnctemplate only.vnc_clean, which was listed in the YAML overview but never described. The entry explains when it runs, that the default now stops only this job's VNC server by display, how it behaves invnc_container, and that an override replaces the default completely.Also fixes the
websockfiy_cmdtypo in thewebsockify_cmdentry.The
vnc_cleanentry describes the behavior from OSC/ood_core#1000, so this should merge after that PR.