[johrstrom]

Please review our Contributing Guide before submitting a pull request.

What does this PR do?

This fixes #313 by using symbols against a native hash to extract submit_host_override

Related issue

Closes #313

Testing

• Tests included
• No tests needed — reason: ___

Checklist

• Follows project code style and conventions
• Documentation provided (if new feature, adapter or behavior change)
• This is a large feature and was discussed in an issue first (if applicable)

Anything else?

Comments on specific changes below

[johrstrom]

The reason the bug exists at all is because OnDemand symbolizes keys

https://github.com/OSC/ondemand/blob/a8120980652cae4b92c5bfb1afb49649d0c66da4/apps/dashboard/app/models/batch_connect/app.rb#L432

So I felt it's best to just symbolize keys here to enforce that within this code base.

Note that a test like this continues to work because even though strings are given, we cast to symbols here.

ood_core/test/job/adapters/systemd_launcher_test.rb

Lines 281 to 286 in 8c5ca82

	def test_submit_host_with_override
	launcher = launcher_instance
	script = build_script(native: { 'submit_host_override' => 'other.osc.edu' })
	assert_equal('other.osc.edu', launcher.submit_host(script))
	end