feat: expose page_nums on retrieval source for page-memory nodes - #313
Merged
Conversation
Make page-memory node page lists a declared source field for results and referenced_chunks, drop unused attach_citation / source-passthrough, and fix related test isolation/mocks so contract suites stay green. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
page_numsinto publicresults[].sourceforchunk_type=page, and onto mapnavreferenced_chunkswhen present.attach_citation/if 'source' in rowpassthrough; fix completion logging to read internal top-level path fields; update AGENTS.md.get_openai_clientmocks and summary_builder live-module binding so worker contract → unit isolation no longer false-fails.Test plan
make check(lint + typecheck)Made with Cursor