Skip to content

Fix warnings on uninstall #1818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
robertbaldyga merged 2 commits into from
Sep 22, 2026
+13 −6
Merged

Fix warnings on uninstall #1818

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b60ca38
Fix warnings on uninstall
robertbaldyga Sep 22, 2026
671f12e
Uninstall experimental features conditionally
robertbaldyga Sep 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions extra/prometheus/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,10 +40,13 @@ ifdef EXPORTER
endif

uninstall:
-$(SYSTEMCTL) disable --now opencas_exporter
rm -f $(DESTDIR)/usr/bin/opencas_exporter
rm -f $(DESTDIR)$(SYSTEMD_DIR)/opencas_exporter.service
$(SYSTEMCTL) daemon-reload
@if [ -f $(DESTDIR)$(SYSTEMD_DIR)/opencas_exporter.service ]; then \
echo "Uninstalling Open-CAS Prometheus exporter"; \
$(SYSTEMCTL) disable --now opencas_exporter; \
rm -f $(DESTDIR)$(SYSTEMD_DIR)/opencas_exporter.service; \
$(SYSTEMCTL) daemon-reload; \
fi
@rm -f $(DESTDIR)/usr/bin/opencas_exporter

clean:
rm -f opencas_exporter
Expand Down
8 changes: 6 additions & 2 deletions utils/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,8 +96,12 @@ uninstall:
$(call remove-file,$(DESTDIR)$(UDEVRULES_DIR)/60-persistent-storage-cas.rules)
@$(UDEV) control --reload-rules

@$(SYSTEMCTL) -q disable open-cas-shutdown
@$(SYSTEMCTL) -q disable open-cas
@if [ -f $(DESTDIR)$(SYSTEMD_DIR)/open-cas-shutdown.service ]; then \
$(SYSTEMCTL) -q disable open-cas-shutdown; \
fi
@if [ -f $(DESTDIR)$(SYSTEMD_DIR)/open-cas.service ]; then \
$(SYSTEMCTL) -q disable open-cas; \
fi
@$(SYSTEMCTL) daemon-reload

$(call remove-file,$(DESTDIR)$(SYSTEMD_DIR)/open-cas-shutdown.service)
Expand Down
Loading