Rename the timeslices table's timeslice_id column to timeslice - #140
Open
nick-gorman wants to merge 2 commits into
Open
Rename the timeslices table's timeslice_id column to timeslice#140nick-gorman wants to merge 2 commits into
nick-gorman wants to merge 2 commits into
Conversation
The tables that reference timeslice windows (network_transmission_path_limits, custom_constraints_rhs) have always called the column timeslice, so any consumer joining limits onto windows had to rename one side first -- the apply-per-timeslice-link-limits branch adds the first such join and with it the first rename shim. Using one name end-to-end removes that seam; the divergence from the path_id/constraint_id suffix convention is accepted. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Eip6Q6HyAwbqVkoKthGA8Z
Codecov Report✅ All modified and coverable lines are covered by tests.
🚀 New features to boost your workflow:
|
The point of the line is that the caller's timeslice_snapshots frame is not mutated; .copy() states that directly instead of leaning on assign returning a new frame. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Eip6Q6HyAwbqVkoKthGA8Z
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Realised that I'd use both
timesliceandtimeslice_idas column names for different tables. This PR does a big cleanup to unify the naming to just usetimeslice. The change needs to touch code in #137 so this PR is currently targeting #137, but I intend to merge #137 and then target this PR at main.