Issue 173 - #179
Open
aryansinha1908 wants to merge 3 commits into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
Adds Prettier-based formatting to the apps/web and packages/protocol workspaces (aligned with the existing apps/server Prettier config) and applies a mechanical formatting pass to reduce style drift and whitespace-only diffs. Also updates contributor guidance and adds a blame-ignore rev list to keep git blame usable after the reformat.
Changes:
- Add workspace-local Prettier configs (
.prettierrc) andformatnpm scripts for@docksight/weband@docksight/protocol. - Apply a mechanical
prettier --writeformatting pass across TS/TSX sources (plus minor doc/table formatting). - Add
.git-blame-ignore-revsentry for the reformat commit and updateCONTRIBUTING.mdwith formatting commands.
Reviewed changes
Copilot reviewed 91 out of 110 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| .git-blame-ignore-revs | Ignore the mechanical Prettier commit in git blame. |
| CONTRIBUTING.md | Document formatting workflow + table/link formatting. |
| apps/server/src/agents/agents.module.ts | Prettier formatting only. |
| apps/server/src/agents/agents.service.spec.ts | Prettier formatting only. |
| apps/server/src/agents/agents.service.ts | Prettier formatting only. |
| apps/server/src/agents/container-inventory.service.ts | Prettier formatting only. |
| apps/server/src/common/database/database.config.ts | Prettier formatting only. |
| apps/server/src/common/database/prisma.module.ts | Prettier formatting only. |
| apps/server/src/common/database/prisma.service.ts | Prettier formatting only. |
| apps/server/src/common/index.ts | Prettier formatting only. |
| apps/server/src/common/redis/redis.module.ts | Prettier formatting only. |
| apps/server/src/common/redis/redis.service.ts | Prettier formatting only. |
| apps/server/src/containers/containers.service.ts | Prettier formatting only. |
| apps/server/src/hosts/dto/update-host.dto.ts | Prettier formatting only. |
| apps/server/src/hosts/hosts.controller.ts | Prettier formatting only. |
| apps/server/src/hosts/hosts.module.ts | Prettier formatting only. |
| apps/server/src/main.ts | Prettier formatting only. |
| apps/server/test/app.e2e-spec.ts | Prettier formatting only. |
| apps/web/.prettierrc | Add Prettier config for the web workspace. |
| apps/web/package.json | Add format script for the web workspace. |
| apps/web/src/app/App.tsx | Prettier formatting only. |
| apps/web/src/app/providers.tsx | Prettier formatting only. |
| apps/web/src/components/ConfirmProvider.tsx | Prettier formatting only. |
| apps/web/src/components/ContainerLogsDrawer.tsx | Prettier formatting only. |
| apps/web/src/components/ContainerMetrics.tsx | Prettier formatting only. |
| apps/web/src/components/ErrorBoundary.tsx | Prettier formatting only. |
| apps/web/src/components/HostCard.tsx | Prettier formatting only. |
| apps/web/src/components/HostSelect.tsx | Prettier formatting only. |
| apps/web/src/components/OsIcon.tsx | Prettier formatting only. |
| apps/web/src/components/StatusBadge.tsx | Prettier formatting only. |
| apps/web/src/components/StatTile.tsx | Prettier formatting only. |
| apps/web/src/components/ToastProvider.tsx | Prettier formatting only. |
| apps/web/src/components/auth/RequireAuth.tsx | Prettier formatting only. |
| apps/web/src/components/charts/Sparkline.tsx | Prettier formatting only. |
| apps/web/src/components/layout/AppShell.tsx | Prettier formatting only. |
| apps/web/src/components/layout/Sidebar.tsx | Prettier formatting only. |
| apps/web/src/components/ui/badge.tsx | Prettier formatting only. |
| apps/web/src/components/ui/button.tsx | Prettier formatting only. |
| apps/web/src/components/ui/card.tsx | Prettier formatting only. |
| apps/web/src/components/ui/copy-button.tsx | Prettier formatting only. |
| apps/web/src/components/ui/data-list.tsx | Prettier formatting only. |
| apps/web/src/components/ui/dropdown.tsx | Prettier formatting only. |
| apps/web/src/components/ui/drawer.tsx | Prettier formatting only. |
| apps/web/src/components/ui/empty-state.tsx | Prettier formatting only. |
| apps/web/src/components/ui/input.tsx | Prettier formatting only. |
| apps/web/src/components/ui/pagination.tsx | Prettier formatting only. |
| apps/web/src/components/ui/skeleton.tsx | Prettier formatting only. |
| apps/web/src/components/ui/tabs.tsx | Prettier formatting only. |
| apps/web/src/features/auth/AuthLayout.tsx | Prettier formatting only. |
| apps/web/src/features/auth/LoginPage.tsx | Prettier formatting only. |
| apps/web/src/features/auth/SetupPage.tsx | Prettier formatting only. |
| apps/web/src/features/containers/ContainersPage.tsx | Prettier formatting only. |
| apps/web/src/features/dashboard/DashboardPage.tsx | Prettier formatting only. |
| apps/web/src/features/hosts/HostsPage.tsx | Prettier formatting only. |
| apps/web/src/features/inventory/InventoryPages.tsx | Prettier formatting only. |
| apps/web/src/features/inventory/InventoryTables.tsx | Prettier formatting only. |
| apps/web/src/features/metrics/MetricsPage.tsx | Prettier formatting only. |
| apps/web/src/features/not-found/NotFoundPage.tsx | Prettier formatting only. |
| apps/web/src/features/settings/SettingsPage.tsx | Prettier formatting only. |
| apps/web/src/hooks/useContainerAction.ts | Prettier formatting only. |
| apps/web/src/hooks/useContainerCommands.ts | Prettier formatting only. |
| apps/web/src/hooks/useContainerInspect.ts | Prettier formatting only. |
| apps/web/src/hooks/useContainers.ts | Prettier formatting only. |
| apps/web/src/hooks/useDocumentTitle.ts | Prettier formatting only. |
| apps/web/src/hooks/useHostInventory.ts | Prettier formatting only. |
| apps/web/src/hooks/useHostMetrics.ts | Prettier formatting only. |
| apps/web/src/hooks/useHosts.ts | Prettier formatting only. |
| apps/web/src/hooks/useRenameHost.ts | Prettier formatting only. |
| apps/web/src/lib/format.ts | Prettier formatting only. |
| apps/web/src/lib/host-name.test.ts | Prettier formatting only. |
| apps/web/src/lib/host-name.ts | Prettier formatting only. |
| apps/web/src/lib/metrics.test.ts | Prettier formatting only. |
| apps/web/src/lib/metrics.ts | Prettier formatting only. |
| apps/web/src/lib/status.ts | Prettier formatting only. |
| apps/web/src/lib/utils.ts | Prettier formatting only. |
| apps/web/src/main.tsx | Prettier formatting only. |
| apps/web/src/services/api.ts | Prettier formatting only. |
| apps/web/src/services/auth.service.ts | Prettier formatting only. |
| apps/web/src/services/hosts.test.ts | Prettier formatting only. |
| apps/web/src/services/hosts.ts | Prettier formatting only. |
| apps/web/src/services/tokenStorage.ts | Prettier formatting only. |
| apps/web/src/stores/auth.ts | Prettier formatting only. |
| apps/web/src/stores/theme.ts | Prettier formatting only. |
| apps/web/src/types/api.ts | Prettier formatting only. |
| apps/web/src/vite-env.d.ts | Prettier formatting only. |
| packages/protocol/.prettierrc | Add Prettier config for the protocol workspace. |
| packages/protocol/package.json | Add format script for the protocol workspace. |
| packages/protocol/src/agent.ts | Prettier formatting only. |
| packages/protocol/src/envelope.ts | Prettier formatting only. |
| packages/protocol/src/errors.ts | Prettier formatting only. |
| packages/protocol/src/index.ts | Prettier formatting only. |
| packages/protocol/src/logs.ts | Prettier formatting only. |
| packages/protocol/src/metrics.ts | Prettier formatting only. |
| packages/protocol/src/types.ts | Prettier formatting only. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
23
to
26
| "test": "tsc -p tsconfig.test.json", | ||
| "lint": "echo \"No lint configured yet\"" | ||
| "lint": "echo \"No lint configured yet\"", | ||
| "format": "prettier --write \"src/**/*.ts\"" | ||
| }, |
Comment on lines
9
to
13
| "lint": "oxlint", | ||
| "preview": "vite preview", | ||
| "test": "vitest run" | ||
| "test": "vitest run", | ||
| "format": "prettier --write \"src/**/*.{ts,tsx}\"" | ||
| }, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds Prettier formatting to
apps/webandpackages/protocolto match the existing configuration inapps/server, preventing future style drift and noisy whitespace diffs.To make this large change reviewable, the PR is structured into three separate commits:
.prettierrc,package.jsonscripts, and updatesCONTRIBUTING.md.prettier --writeoutput applied to all source files..git-blame-ignore-revsfile containing the SHA of the mechanical formatting commit sogit blameremains useful.Type of change
Areas touched
apps/server(NestJS)apps/web(React / Vite)apps/agent(Go)packages/protocol(shared WebSocket contracts)infrastructure/.github/workflowsdocsRelated issues
Closes #173
How to test
npm run format --workspace=@docksight/webandnpm run format --workspace=@docksight/protocol. Running it should produce zero modified files, proving the formatting is fully applied.npm run lint --workspace=@docksight/webto verify that oxlint and Prettier are not fighting or throwing conflicting errors.npm run build --workspace=@docksight/webto verify the build still succeeds.Checklist
docs/if module boundaries or the protocol changed. (UpdatedCONTRIBUTING.md)docs/decisions/if this is a larger architectural change.Local checks