Repository navigation
Fix routing order and glossary jar loading - #2820
Merged
simonredfern merged 1 commit intoJun 1, 2026
Merged
simonredfern merged 1 commit into
simonredfern merged 1 commit into
Conversation
Routing order (Http4sApp): v510/v600/v500 were placed before v700, causing every v7.0.0 request to traverse three extra middleware hops and produce spurious DEBUG 'No match' log entries. Reorder to v700 -> v600 -> v510 -> v500 so each request hits the correct version middleware on the first try. Glossary jar loading (Glossary.scala): getListOfFiles() used new File(url.getPath) which breaks under the jar: protocol (path contains '!/' separator that File cannot resolve). Replace with getGlossaryEntries() that dispatches on url.getProtocol: - file: protocol keeps the existing File-based directory scan (IDE / unpacked) - jar: protocol uses JarURLConnection + jar.entries() enumeration and getInputStream() to read .md content directly from the fat-jar Verified locally: jar mode now logs INFO for the jar: URL (no ERROR), glossary endpoint returns 851 items including all 436 file-backed entries (was 0 in jar mode).
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Routing order (Http4sApp): v510/v600/v500 were placed before v700, causing every v7.0.0 request to traverse three extra middleware hops and produce spurious DEBUG 'No match' log entries. Reorder to v700 -> v600 -> v510 -> v500 so each request hits the correct version middleware on the first try.
Glossary jar loading (Glossary.scala): getListOfFiles() used new File(url.getPath) which breaks under the jar: protocol (path contains '!/' separator that File cannot resolve). Replace with getGlossaryEntries() that dispatches on url.getProtocol:
Verified locally: jar mode now logs INFO for the jar: URL (no ERROR), glossary endpoint returns 851 items including all 436 file-backed entries (was 0 in jar mode).