feat(datasets): add column data-type badges and sorting to ParquetViewer - #1547
Open
sabhi128 wants to merge 2 commits into
Open
feat(datasets): add column data-type badges and sorting to ParquetViewer#1547sabhi128 wants to merge 2 commits into
sabhi128 wants to merge 2 commits into
Conversation
sabhi128
requested review from
hiveer,
ice201508,
jialudev,
ymh6315431,
yoiteyou and
zhendi
as code owners
September 5, 2026 14:27
There was a problem hiding this comment.
🟡 Changes recommended
Default client-side sorting will sort numeric columns lexicographically due to stringified cell values, producing incorrect ordering for multi-digit numbers.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
This PR improves the dataset preview table in ParquetViewer.vue by displaying each column’s data type alongside the header and enabling client-side sorting on columns.
Changes:
- Render compact data-type badges in the table header using
columns_typefrom the preview API response. - Enable column sorting on the Element Plus table.
- Add a unit test asserting column header + type-badge rendering.
File summaries
| File | Description |
|---|---|
| frontend/src/components/datasets/ParquetViewer.vue | Adds header rendering for type badges and enables sorting on table columns. |
| frontend/src/components/tests/datasets/ParquetViewer.spec.js | Adds a unit test covering column header/type badge rendering. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 3
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
This PR enhances the dataset preview experience in
ParquetViewer.vueby exposing column data types and enabling interactive sorting.Key Enhancements:
columns_typearray from the dataset preview API response.str,int64,float,list,dict) alongside column headers.sortableon table columns, allowing users to sort dataset rows directly in the browser.ParquetViewer.spec.jsasserting proper rendering of column names and their respective data-type badges.