Skip to content

[backend/worker] handle too large items (#12816) - #12632

Merged
Jeremy Cloarec (JeremyCloarec) merged 10 commits into
masterfrom
oob/inputSizeHardLimit
Oct 16, 2025
Merged

Jeremy Cloarec (JeremyCloarec) merged 10 commits into
masterfrom
oob/inputSizeHardLimit

Conversation

@JeremyCloarec

@JeremyCloarec Jeremy Cloarec (JeremyCloarec) commented Oct 3, 2025 •

Copy link
Copy Markdown
Contributor

Proposed changes

  • add new internal queue too-large-bundle
  • add objects_max_refs config to worker.py
  • in worker, if item has too many dependencies, it is sent to the too-large-bundle queue instead of being ingested

client PR: OpenCTI-Platform/client-python#982
doc PR: OpenCTI-Platform/docs#360

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case (coverage and e2e)
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

@JeremyCloarec Jeremy Cloarec (JeremyCloarec) added the multi-repository For contribution that requires PR in several repository label Oct 3, 2025
@github-actions github-actions Bot added the filigran team Item from the Filigran team. label Oct 3, 2025
@JeremyCloarec
Jeremy Cloarec (JeremyCloarec) marked this pull request as ready for review October 3, 2025 15:10
@codecov

codecov Bot commented Oct 3, 2025 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 66.87%. Comparing base (a2cdb90) to head (3c76cf8).
⚠️ Report is 11 commits behind head on master.

Files with missing lines Patch % Lines
...-platform/opencti-graphql/src/database/rabbitmq.js 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #12632      +/-   ##
==========================================
+ Coverage   66.53%   66.87%   +0.34%     
==========================================
  Files         752      752              
  Lines       79741    79847     +106     
  Branches     8557     9021     +464     
==========================================
+ Hits        53056    53400     +344     
+ Misses      26685    26447     -238     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment thread opencti-worker/src/config.yml.sample Outdated
Comment thread opencti-platform/opencti-graphql/src/database/rabbitmq.js
log_level: 'info'
telemetry_enabled: false No newline at end of file
telemetry_enabled: false
objects_max_refs: 0 No newline at end of file

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did you manage to find a good default value to be used in Filigran SaaS ?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not yet, haven't tested enough to have a clear guideline on the value to set

Comment thread opencti-worker/src/worker.py Outdated
Comment thread opencti-worker/src/worker.py Outdated
Comment thread opencti-worker/src/worker.py Outdated
Comment thread opencti-worker/src/push_handler.py Outdated
Comment thread opencti-worker/src/push_handler.py Outdated
Comment thread opencti-worker/src/worker.py
@JeremyCloarec Jeremy Cloarec (JeremyCloarec) changed the title [backend/worker] handle too large items [backend/worker] handle too large items (#12816) Oct 15, 2025
Comment thread opencti-worker/src/push_handler.py
@JeremyCloarec
Jeremy Cloarec (JeremyCloarec) merged commit 5b80965 into master Oct 16, 2025
11 checks passed
@JeremyCloarec
Jeremy Cloarec (JeremyCloarec) deleted the oob/inputSizeHardLimit branch October 16, 2025 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

filigran team Item from the Filigran team. multi-repository For contribution that requires PR in several repository

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add a way to send objects from bundles with too many refs to a dead letter queue

4 participants