Skip to content

[backend] now keep description & content from baseData in container wrapper (#12870) - #12872

Merged
Jeremy Cloarec (JeremyCloarec) merged 2 commits into
masterfrom
issue/12870
Oct 21, 2025
Merged

Jeremy Cloarec (JeremyCloarec) merged 2 commits into
masterfrom
issue/12870

Conversation

@JeremyCloarec

@JeremyCloarec Jeremy Cloarec (JeremyCloarec) commented Oct 21, 2025 •

Copy link
Copy Markdown
Contributor

Proposed changes

  • now keep description & content from baseData in container wrapper

related client PR: OpenCTI-Platform/client-python#1020

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case (coverage and e2e)
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

@codecov

codecov Bot commented Oct 21, 2025 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 36.36364% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 66.40%. Comparing base (23dff9c) to head (412ef7b).
⚠️ Report is 22 commits behind head on master.

Files with missing lines Patch % Lines
...raphql/src/modules/playbook/playbook-components.ts 36.36% 7 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master   #12872   +/-   ##
=======================================
  Coverage   66.39%   66.40%           
=======================================
  Files         760      760           
  Lines       80172    80181    +9     
  Branches     8583     8587    +4     
=======================================
+ Hits        53233    53241    +8     
- Misses      26939    26940    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@JeremyCloarec
Jeremy Cloarec (JeremyCloarec) marked this pull request as ready for review October 21, 2025 08:41

@aHenryJard A. Jard (aHenryJard) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, all good to me

@JeremyCloarec
Jeremy Cloarec (JeremyCloarec) merged commit 1098d00 into master Oct 21, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

filigran team Item from the Filigran team. multi-repository For contribution that requires PR in several repository

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[playbook] Description is not reported when wrapping to a container

3 participants