Repository navigation
Conversation
The nchunks=0 target and the crossing floor were mirrored by hand in two test files. They are now min_crossing_chunks(msing) and auto_chunk_target(msing), used by balance_integration_chunks and both tests; one deliberate assertion pins the formula so a src change still fails loudly instead of propagating silently. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Contributor
|
This pull request is missing an assignee and a reviewer. If you are not ready to name them, mark this pull request as a draft. |
… pin it by value - The struct docstring, docs/src/stability.md and the test comment now point at auto_chunk_target / min_crossing_chunks instead of restating the formula. - The test pins auto_chunk_target and min_crossing_chunks by value (a spec), not by a copy of the expression. - auto_chunk_target drops a max whose floor could never win (9m+8 > 2m+3 for m ≥ 0); value-identical for every msing. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Collaborator
|
@d-burg should this be opened and assigned a reviewer? |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release note
diiid_n1_riccatiis bit-identical head vs baseThe
nchunks = 0auto chunk-count target and the crossing floor were each written out in three places: the authoritative formula insidebalance_integration_chunksplus hand-copied mirrors inruntests_parallel_integration.jlandruntests_decomposition_invariance.jl. They are now single functions —ForceFreeStates.auto_chunk_target(msing)andForceFreeStates.min_crossing_chunks(msing)— used by the solver and both test files, and the struct docstring,docs/src/stability.mdand the test comments now point at them instead of restating the formula.Regression report
regress --cases diiid_n1_riccati --refs 30eb52073,a47f409f0 --force(base = #362's headfeature/thread-invariance, so the comparison isolates exactly this refactor; raw shas, both sides fresh):Validation
runtests_parallel_integration.jlata47f409f0,julia -t 4, fresh worktree: 95/95runtests_decomposition_invariance.jlsame conditions: 11/11feature/thread-invariance(it filters on basedevelop/main); it will run once the base is retargeted after Test - TEST - ⏸️ Decomposition invariance of the unified Riccati Delta-prime path #362 merges — the local runs above cover the gapNotes for reviewers
runtests_parallel_integration.jl:auto_chunk_target.((0, 1, 5)) == (8, 17, 53)andmin_crossing_chunks.((0, 1, 5)) == (3, 5, 13). A change to the src formula fails that test and has to update a spec, rather than being pasted into a copy of the expression. (The harnessdiiid_n1_riccaticase would also catch it through the chunk list.)auto_chunk_targetdrops themax(2m+3, …)from the old expression:9m+8 > 2m+3for everym ≥ 0, so the floor could never win. Value-identical for everymsing.min_bvp_intervalsconditioning rationale moved from the inline comment intoauto_chunk_target's docstring, which also corrects the old comment's stale "at least 5 non-crossing sub-chunks" to the 8 the code uses.b7ace7893):runtests_parallel_integration.jl96/96.feature/thread-invariance), sinceruntests_decomposition_invariance.jlonly exists there; retarget todevelopafter Test - TEST - ⏸️ Decomposition invariance of the unified Riccati Delta-prime path #362 merges.Draft until #362 lands and Daniel names reviewer/assignee.
🤖 Generated with Claude Code