Repository navigation
Tearing - FEATURE - 🌱 Add a per-surface omega_E_kHz override of the kinetic-file E×B rotation - #519
Draft
d-burg wants to merge 1 commit into
Conversation
…etic-file E×B rotation A table keyed by m/n replaces the kinetic file's Ω_E on the listed surfaces, for rotation scans of the coupled determinant. Unlisted surfaces keep the file value; a key matching no analysed surface is an error. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
|
This pull request is missing a reviewer. If you are not ready to name them, mark this pull request as a draft. |
1 similar comment
Contributor
|
This pull request is missing a reviewer. If you are not ready to name them, mark this pull request as a draft. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release note
You can now replace the kinetic file's E×B rotation on chosen rational surfaces from the deck, to scan rotation in a coupled SLAYER run without editing the profile file.
Surfaces not listed keep the file's value. The resolved rotation is written to
Tearing/PerSurface/omega_Eas before.Regression report
regress --cases diiid_slayer_n1,diiid_slayer_n1_coupled --refs 6a9d9e848,744225414on feynman: the parent PR's head (#463, with develop merged) against this branch. All 24 quantities are unchanged, and the stored values are bit-identical.Notes for reviewers
omega_E, but given as Ω_E/2π in kHz where the file is in rad/s."2/1", not"02/1".omega_E, and the run warns.run_slayer_from_inputs(an override on one surface while the other keeps the file value, and an unknown key).NO MERGE WITHOUT HUMAN REVIEW. This PR is a draft and needs a named human reviewer before it can be considered for merge.
🤖 Generated with Claude Code