feat: add inline commands for theme build and watch in the themes view - #17
Merged
Conversation
fix: improve error handling with user-friendly messages in ThemesProvider
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces improvements to the MageForge extension's theme management commands and enhances error handling for a better user experience. The main changes add new inline commands for building and watching themes directly from the view, improve error messaging for common environment issues, and refactor how the themes tree view is registered.
Theme command enhancements:
mageforge.theme.buildInlineandmageforge.theme.watchInlinewith corresponding entries inpackage.jsonand registered them in the extension activation logic, allowing users to build or watch themes directly from the themes view. [1] [2] [3]registerTreeDataProvidertocreateTreeView, enabling richer view features.Error handling improvements:
execMageforgeto provide a fallback message if bothstderrand the error message are missing.