Conversation
Closes out CodeQL java/missing-override-annotation (1327 alerts, 226 files): every flagged method genuinely overrides/implements a super type method, verified by the compiler itself (javac rejects an incorrect @OverRide), plus a full mvn install run across all touched modules (1556 tests, 0 failures).
vharseko
added
java
Member
Author
|
Closing in favor of #136, which already covers the exact same 226 files (identical scope: add missing @OverRide annotations for java/missing-override-annotation) and has a fully green CI matrix across all OS/JDK combinations. Duplicate discovered after the fact — see this PR's own thread for the investigation. Apologies for the noise. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes out the CodeQL
note-severity categoryjava/missing-override-annotation: 1327 alerts across 226 files.@Overrideannotation. Added it in each case.@Overrideon a method that does not actually override anything is a compile error in Java, so the fullmvn installbuild (below) is itself a correctness check on every one of the 1327 insertions — the compiler would have rejected any false positive.Test plan
mvn install -DskipITs -T 1Con the full reactor (all modules, including LDAP/OpenDJ integration tests) — clean build, 1556 tests, 0 failures, 0 errors.