GASP based tail geometry work - #1285
Merged
Merged
Conversation
…sign:compute_vtail_volume_coeff
…TestEmpennageGroup.
…lTail.VOLUME_COEFFICIENT to BWBPreMissionGroupTest
….COMPUTE_VTAIL_VOLUME_COEFF
xjjiang
marked this pull request as ready for review
September 2, 2026 16:44
This was referenced Sep 2, 2026
jkirk5
reviewed
Sep 8, 2026
Kenneth-T-Moore
approved these changes
Sep 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Here is a summary of this PR:
MomentRatiothat computesAircraft.HorizontalTail.MOMENT_RATIOandAircraft.VerticalTail.MOMENT_RATIO.--
Aircraft.Design.COMPUTE_HTAIL_VOLUME_COEFF--
Aircraft.Design.COMPUTE_VTAIL_VOLUME_COEFF.--
Aircraft.HorizontalTail.MOMENT_RATIO,--
Aircraft.VerticalTail.MOMENT_RATIO,--
Aircraft.HorizontalTail.VOLUME_COEFFICIENT,--
Aircraft.VerticalTail.VOLUME_COEFFICIENT,ChordCheck.This component
ChordCheckdoes not have an output. It is added to address the issue in #1089. In GASP, horizontal tail root chord, taper ratio and aspect ratio are computed and updated during the run. But In Aviary, taper ratio and aspect ratio are inputs and they can not be updated during a simulation.Ideally, they should be set in
preprocessors.pyif they need to be updated. But the computation is too complicate to be handled inpreprocessors.py. So, what I am doing is to issue warnings for users to adjust their dataset and rerun.GASP has another warning message when horizontal tail area is more than half of that of wing. That message is for Boeing's joined winged concept. This concept is not in the version of GASP that we have nor in Aviary. So, I don't add it in this PR.
See issue #1289 for removing
Aircraft.Design.COMPUTE_HTAIL_VOLUME_COEFFandAircraft.Design.COMPUTE_VTAIL_VOLUME_COEFF.Related Issues
Backwards incompatibilities
None
AI Usage
None.