Skip to content

Incorrect Units for Corrected Flow and Speed in Turbine Element Compute #120

Description

@Willaoh33

Inside CorrectedInputsCalc within turbine.py, Wp (corrected flow) is declared with units lbm/s but is computed as W_in * Tt ** 0.5 / Pt which results in units of lbm * degR ** 0.5 / s / psi.

Likewise, the same class declares Np (corrected speed) with units rpm but computes it as Nmech * Tt ** 0.5 resulting in units of rmp / degR ** 0.5.

It seems that the dimensional temperatures and pressures were confused with non-dimensional temperature and pressure ratios vs reference values.

The compressor computes non-dimensional temperatures and pressures for flow and speed corrections so the declared and computed units agree. Should the turbine model be adjusted to do the same?

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions