(I003) update usage of variable_filter#464
Conversation
|
I'm not sure what's going on with these masses of huuge PRs (who will review that in finite time?!), if that is an AI running wild or not. On the off chance-that this is some kind of structured stacked-feature way of developing features, have you heard that github now formally supports "stacked pull requests"? https://github.github.com/gh-stack/ |
I'm the AI running wild ;-) at the end this set of patches was created over a long time. It started quite small (some discussion in PR #404; development started mid of 2025). The small changes accumulated (and new ideas were added) but I never had it down to the point as commit ready steps. However, to get it into OMPython I had to scale it down to handleable pices. But - due to additional requests / discussions - there are new items added at the top ... The original code is spitted into even smaller commits which show some of the try-and-error development; I reworked it (see: https://github.com/syntron/OMPython/tree/syntron_RFC) and asked if these small commits could be merged into 'steps' of single commit PRs to keep the rebase work low. The stacked PR idea sounds fine - but is is at the moment not rolled out :-( |
syntron
force-pushed
the
I003_filter
branch
2 times, most recently
from
65c300c to
7d70497
Compare
[README.md] small updates [__init__] small updates
* ModelExecutionData => ModelExecutionRun * ModelExecutionCmd => ModelExecutionConfig
[pylint] fix 'R1729: Use a generator instead 'all(isinstance(item, tuple) for item in val_evaluated)' (use-a-generator)' [pylint] fix 'W0237: Parameter 'expr' has been renamed to 'command' in overriding 'OMCSessionZMQ.sendExpression' method (arguments-renamed)' [pylint] [OM*Path*] fix pylint messags about incompatible definitions
[ModelExecutionException] catch exception if ModelExecutionCmd.run() is used [bugfix] [ModelicaSystem] fix exception; use ModelicaSystemError (instead of wrong ModelExecutionException) [bugfix] [ModelicaSystemABC] fix _prepare_input_data() - ensure returned data is dict[str, str]
[compatibility] add class wrapper to provide the depreciation message [ModelicaSystem] fix / improve wrapper functions for v4.0.0 compatibility [ModelicaSystemABC] additional checks for setInputs() [test_ModelicaSystemOMC] add tests for setInputs() [__init__] define ModelicaSystemDoE at the right point (=> compatibility layer) [__init__] remove duplicate 'OMCSessionABC' in __all__
[ModelicaSystemABC] remove code for (depreciated) arguments in set*() methods * define code in the compatibility layer in class ModelicaSystem [test_ModelicaSystem(OMC)] update tests * for new version: remove usage of old definition * for compatibility version: test old definition
[OMCSessionABC] remove execute(); still available in compatibility v4.0.0 [ModelicaSystem] define _set_compatibility_helper() as static [ModelExecutionCmd] remove depreciated simflags [test_ModelSystemCmd/ModelExecutionCmd] fix test due to changes [ModelicaSystemCmd] cleanup - do not define (unused / not useable) class
…ased on the content of a CSV file
…ut to OMPython input based on code written by joewa (see OpenModelica#447 (comment))
* use public function `ModelicaSystemABC.set_variable_filter()` to define * process it in `ModelicaSystemABC._process_override_data()` as command line argument
2 participants
update handling of variable_filter
use public function
ModelicaSystemABC.set_variable_filter()to defineprocess it in
ModelicaSystemABC._process_override_data()as command line argumentuse new processing for variable_filter
add unittest test_variable_filter()