Repository navigation
NMS-9014: Provisioning detector reference docs - #8988
Closed
joseanesONMS wants to merge 3 commits into
Closed
joseanesONMS wants to merge 3 commits into
joseanesONMS wants to merge 3 commits into
Conversation
The JmxMonitor had a reference page, but the Jsr160Detector, the only JMX detector registered for provisioning, had none. Parameters and defaults come from JMXDetector, GenericJMXDetectorFactory, and JmxConnectionConfigBuilder; examples follow default-foreign-source.xml.
Twenty-four detectors registered as ServiceDetectorFactory services on develop had no reference page, including the line-oriented, SNMP-based, DHCP, NTP, ICMP, SMB, SSH, RADIUS, and general purpose detectors. Parameters and defaults come from each detector class and its base classes in opennms-provision and protocols/radius; examples validate against foreign-sources.xsd.
GenericServiceDetectorFactory sets detector parameters as bean properties, so the documented keys must match the setters: brokerURL and useNodeLabel (ActiveMQDetector), storedProcedure (JdbcStoredProcedureDetector), supported (LoopDetector), and authEnabled (WebDetector). Defaults now follow the code: DBTools.DEFAULT_URL for the JDBC detectors, the unset TcpDetector banner, HttpsDetector's port 443 and maxRetCode 500, and the WSManWQL service name.
Contributor
Author
|
Reopened as #8998 from a branch without the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Documents the provisioning detector reference pages, split out of #8984; content checked against the code on develop, one commit per ticket.
reference/…/detectors/Jsr160Detector.adoc(new),JmxMonitor.adocopennms-provision/opennms-detector-jmx/…,core/jmx/api/…/JmxConnectionConfig*.javareference/…/detectors/*.adocopennms-provision/opennms-detector-*,protocols/radius/…/detector,opennms-provision-api/…/support/*Detector*.javaCorrections to existing docs (separate
NMS-9014: Fix …commits, each can be dropped on its own)brokerURL,useNodeLabel,storedProcedure,supported,authEnablednames; JDBCurl, WQLserviceName, TCPbanner, HTTPS defaultsNot addressed
The docs build adds no warnings (develop's two existing ones remain).
External References