Repository navigation
NMS-12662: Performance data collection docs - #8989
Closed
joseanesONMS wants to merge 7 commits into
Closed
joseanesONMS wants to merge 7 commits into
joseanesONMS wants to merge 7 commits into
Conversation
The collectd package elements storeByIfAlias, ifAliasDomain, storeByNodeID, storFlagOverride, and ifAliasComment were undocumented; storFlagOverride only has meaning together with the others. Behavior is taken from collectd-configuration.xsd, CollectionSpecification, ServiceParameters, IfInfo, and AliasedResource.
org.opennms.netmgt.collectd.strictInterval has defaulted to true since NMS-14259, but neither the property nor its effect on collection scheduling was documented. Behavior and default are taken from CollectableService.
Service monitors and detectors have a common parameter section, but collectors did not, so thresholding-enabled, ttl, and the Minion targeting parameters were only partly documented per collector. The list is limited to parameters handled generically by CollectableService, CollectorRequestBuilderImpl, and RpcTargetHelper.
…ests
The XmlCollector page used placeholders such as {ipaddr} in examples but never listed which ones exist or where they apply, and linked to the unrelated filter parameters page.
The list comes from AbstractXmlCollectionHandler.parseString and XmlCollector.filterParameters.
The resourceLabel attribute of resource types supports subIndex, hex, and string expressions that shipped resource types such as cesServerFarmRserverEntry rely on, but none of them were documented. Semantics are taken from GenericIndexResourceType, with a worked example for the Cisco SLB resource type.
The SnmpCollector page showed datacollection-config.xml and an include example, but did not explain the elements of a data collection group (group, mibObj, systemDef, ipList) or the include-collection options. Element semantics are taken from datacollection-config.xsd, DataCollectionConfigParser, and DataCollectionConfigLookupUtils.
The root element attribute is rrdRepository (datacollection-config.xsd and @XmlAttribute in DatacollectionConfig.java), not rrd-repository.
Contributor
Author
|
Reopened as #8999 from a branch without the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Documents the collectd and collector configuration, split out of #8984; content checked against the code on develop, one commit per ticket.
storFlagOverrideand the ifAlias storage optionsoperation/…/collectd/collection-packages.adoccollectd-configuration.xsd,CollectionSpecification.java,IfInfo.javastrictIntervaloperation/…/collectd/configuration.adoc,reference/…/system-properties.adocopennms-services/…/collectd/CollectableService.javareference/…/performance-data-collection/introduction.adocCollectableService.java,CollectorRequestBuilderImpl.java,RpcTargetHelper.javareference/…/collectors/xml.adocprotocols/xml/…/AbstractXmlCollectionHandler.java,XmlCollector.javasubIndexand other resource label expressionsoperation/…/resource-types.adocopennms-dao/…/GenericIndexResourceType.javareference/…/collectors/SnmpCollector.adocdatacollection-config.xsd,DataCollectionConfigParser.javaCorrections to existing docs (separate
NMS-12662: Fix …commits, each can be dropped on its own)rrdRepositoryattribute namedatacollection-config.xsdThe docs build adds no warnings (develop's two existing ones remain).
External References