Repository navigation
NMS-13978: Remove XmlTestNoCastor - #9009
Merged
Merged
Conversation
XmlTestNoCastor has been an empty subclass of XmlTest since Castor was removed in NMS-9135: it only forwarded its constructor and overrode nothing. The 146 test classes that extended it now extend XmlTest, so they inherit exactly the same five round-trip and schema tests. Running the affected classes in all 29 modules before and after gives identical surefire results: 148 suites, 1084 tests, no failures. No other reference to XmlTestNoCastor remains in the repository.
marshallmassengill
approved these changes
Oct 22, 2026
Contributor
Author
|
@marshallmassengill Merging with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the empty
XmlTestNoCastortest base class, test code only.XmlTestNoCastorremoved; its 146 subclasses extendXmlTestExternal References