Repository navigation
NMS-14732: Remove files left by retired features - #9012
Open
joseanesONMS wants to merge 4 commits into
Open
joseanesONMS wants to merge 4 commits into
joseanesONMS wants to merge 4 commits into
Conversation
The Slack and Mattermost notification strategies were replaced by the Webhook strategy, and nothing reads the org.opennms.netmgt.notifd.slack.* or .mattermost.* properties these templates generated: git grep finds them only in the templates and the webhook migration table in the docs. No container entrypoint, test or other confd file refers to the templates. The matching sections of CONFD_README.md go with them. confd ignores keys that have no template, so an existing horizon-config.yaml that still sets opennms.notifd.slack or .mattermost keeps working.
The remote poller and its GWT UI were removed in NMS-12653. The stylesheet was only built because webpack turns every file under assets/style into an entry; git grep finds no reference to remote-poller-gwt in any JSP, GWT module, webpack/package config, Java or other stylesheet.
RSS feeds were removed long ago and rss.jsp now holds only the license header and a stray "%>", so it renders an empty page. git grep finds no link to it from web.xml, menus, other JSPs, Java, or tests; the only remaining mentions are the /rss.jsp* Basic-auth chain in applicationContext-spring-security.xml and an Acegi-era example in the Dashboard docs, both left as they are. A request for /rss.jsp now gets a 404 instead of an empty 200.
marshallmassengill
requested changes
Oct 22, 2026
marshallmassengill
left a comment
marshallmassengill
left a comment
Contributor
There was a problem hiding this comment.
With the rss.jsp removal, applicationContext-spring-security.xml still carries a dedicated filter chain (lines 396 to 401) and the org.opennms.web.rss feed classes still exist. They are now dead code guarding a 404. I think you can remove that here too.
rss.jsp was the only user of the org.opennms.web.rss feed classes and the only URL matched by the BASIC-auth /rss.jsp* filter chain, so both are dead now that the page is gone. The feed classes were also the only users of ROME, so the dependency and its dependencyManagement entry go too; the webapp's runtime dependencies lose rome and rome-utils and nothing else.
Contributor
Author
|
@marshallmassengill Removed in bfed613: the |
marshallmassengill
approved these changes
Oct 23, 2026
marshallmassengill
left a comment
marshallmassengill
left a comment
Contributor
There was a problem hiding this comment.
I think this is good to go. I would wait for @cgorantla's approval before merging.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes files and code left behind by retired features; nothing a running system uses changes.
remote-poller-gwt.css, emptyrss.jsp(one commit each)horizon-config.yamlkeys are ignored by confd;/rss.jspreturns 404 instead of an empty pageorg.opennms.web.rssfeed classes, the BASIC-auth/rss.jsp*Spring Security chain, and the ROME dependencyrss.jspwas the classes' only user and the chain's only URL; ROME had no other userromeandrome-utilsno longer ship in the webapp; nothing else in its runtime dependencies changesExternal References