Repository navigation
NMS-20482: Hide the Edit button on the Vue dashboard - #9018
Open
joseanesONMS wants to merge 1 commit into
Open
joseanesONMS wants to merge 1 commit into
joseanesONMS wants to merge 1 commit into
Conversation
The new Vue dashboard is being rolled out in stages to reduce risk: first the homepage moves to Vue as a read-only view, and editing is enabled in a later release. The Edit button is the only entry point to edit mode, so it is hidden behind a showEditButton flag; the edit-mode controls, store actions and the admin-only PUT are left in place so the feature can be turned back on by flipping the flag.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hides the Edit button on the new Vue dashboard so the homepage ships as a read-only view first.
Editing is disabled in this first release to lower the risk of the move to Vue, and will be turned on later by flipping one flag.
showEditButtonconstant, set tofalse, inDashboardToolbar.vue; it was already admin-only.External References