Skip to content

fix crash when some long cam-id copy - #1466

Merged
agalasso merged 1 commit into
OpenPHDGuiding:masterfrom
278261631:master
Sep 12, 2026
Merged

agalasso merged 1 commit into
OpenPHDGuiding:masterfrom
278261631:master

Conversation

@278261631

Copy link
Copy Markdown
Contributor

Under Windows, the x86-compiled binary crashes due to an out-of-bounds copy when cameras with relatively long IDs are connected.
now switched to using CAMERA_ID_LENGTH as the length definition (currently=64), and it has been compiled and passed testing.

my@qhyccd.com

@278261631
278261631 marked this pull request as draft September 10, 2026 08:37
@278261631
278261631 marked this pull request as ready for review September 10, 2026 08:37

@agalasso agalasso left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the fix

@agalasso
agalasso merged commit 386c166 into OpenPHDGuiding:master Sep 12, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants