Repository navigation
feat: product images, and drop the page headers - #6
Merged
Merged
Conversation
Removes the title-and-description block from every screen. It repeated what the sidenav already says and pushed the actual content down. Page actions moved onto the filter bar, so they cost no vertical space of their own, and the content now starts at the top of the viewport. Adds the product image: a picker with a live preview in the form, and a thumbnail column in the table. The image is uploaded after the item is saved, because it can only be attached to an item that exists. If that second call fails the message says the product saved but the image did not, rather than implying the whole thing failed. Also restores the products filter bar. It was written in the previous change but the edit that inserted it silently did not match, and the verification pass checked sorting on products and filtering on orders - so nothing caught that products had no filter bar at all. Searching and the status facet work there now. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #5. Pairs with OpenTaberna/fastapi#36, now merged.
Page headers gone
Every screen opened with a title and a sentence of description, repeating what the sidenav
already says and pushing the content down. All removed — the
ot-page-headercomponent isdeleted rather than left unused.
Page actions moved onto the filter bar, on the same row as the filters, so they cost no
vertical space of their own. Content now starts at the top of the viewport.
Verified across every route:
Product images
A picker with a live preview in the form, and a thumbnail column in the table.
The image is uploaded after the item is saved, because it can only be attached to an
item that already exists. If that second call fails, the message says the product saved but
the image did not — rather than implying the whole operation failed, which would send
someone hunting for a product that is actually there.
Object-URL previews are revoked when replaced or cleared, so opening the form repeatedly
does not leak.
A bug from the previous PR
The products filter bar was never actually there. It was written in #4, but the edit
that inserted it silently did not match, and my verification checked sorting on products
and filtering on orders — so nothing caught that products had no filter bar at all. It
shipped missing. Restored here, and searching plus the status facet both work:
Worth naming because the lesson is about the check, not the code: verifying a feature on
one screen said nothing about the screen where it was missing.
Verification
Driven against the live stack:
Images were uploaded through the form, not the API, so the whole path is covered —
file picker, multipart request, token attachment, list refresh, thumbnail render.