Repository navigation
fix: load product images through the API instead of the storefront origin - #9
Merged
Merged
Conversation
…igin Closes #8 Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #8
ApiService.items()anditem()now resolve API-relative media paths (main_image,gallery) againstapiUrl:/v1/items/{uuid}/image→/api/v1/items/{uuid}/image. Absolute URLs and missing images are untouched. The cart stores the items these calls return, so the shop grid, product page and cart are all fixed. README notes it.Verification
npx ng test --watch=false(newsrc/app/core/api.service.spec.ts)Also checked in the browser against the local dev stack (storefront via
docker compose, 40 items with uploaded images): images now render on /shop, /shop/:id and /cart; before, every one was broken.🤖 Generated with Claude Code