Conversation
added 2 commits
September 23, 2026 12:56
When retrieving an uploaded file fails, encode_base64_from_url() returns an empty string. The informatieobject was still created with an empty 'inhoud' and reported as successful. Skip creation instead, so the upload is reported as failed. Same for an empty submission PDF.
Scottielee33
force-pushed
the
fix/skip-empty-informatieobject-content
branch
from
September 23, 2026 10:56
435f88c to
15d5431
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When retrieving an uploaded file fails (timeout, non-2xx response, empty body),
encode_base64_from_url()logs an error and returns''.prepare_information_object_args()does not check this, so anenkelvoudiginformatieobjectis still created with an emptyinhoud, connected to the zaak and counted as a successful upload. The receiving DMS ends up with an empty document and the submission is not flagged as failed.The same applies to a 0-byte submission PDF in
prepare_args_pdf().Change
AbstractCreateUploadedDocumentsAction::prepare_information_object_args()returns an empty array when the content is empty.create_information_object()then returnsnull, soadd_uploaded_documents()returnsfalseand the existingZaakUploadException/ transaction reporting path handles it.AbstractCreateSubmissionPDFAction::prepare_args_pdf()also treats empty file contents as a failure.encode_base64_from_url()now also logs an error when the response body is empty (non-2xx and request errors were already logged), so every failed retrieval can be traced to a URL.