Skip to content

Feat/filter zaken on zaaktypen - #54

Merged
mvdhoek1 merged 4 commits into
mainfrom
feat/filter-zaken-on-zaaktypen
Sep 22, 2026
Merged

mvdhoek1 merged 4 commits into
mainfrom
feat/filter-zaken-on-zaaktypen

Conversation

@mvdhoek1

@mvdhoek1 mvdhoek1 commented Aug 6, 2026

Copy link
Copy Markdown
Contributor
Screenshot 2026-08-06 at 08 57 22 Screenshot 2026-08-06 at 08 57 01

@mvdhoek1
mvdhoek1 marked this pull request as ready for review August 14, 2026 11:11
Comment thread src/WPCron/Events/PopulateZaaktypen.php Outdated
use function OWC\ZGW\apiClientManager;

/**
* Cron event that pre-fetches zaaktypen for all configured suppliers.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dubbelop met de phpdoc hierboven?

use OWC\ZGW\Support\Collection;

/**
* Adapter for fetching zaaktypen to use as select options.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hier ook


private function get_zaaktype_timestamp( Zaaktype $zaaktype ): int
{
if ( ! $zaaktype->versiedatum instanceof DateTimeImmutable) {

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Jij weet beter wat die API teruggeeft denk ik, maar is een versienummer niet logischer dan een versiedatum?

@mvdhoek1
mvdhoek1 force-pushed the feat/filter-zaken-on-zaaktypen branch 2 times, most recently from 577f0b7 to 961c821 Compare September 1, 2026 08:15
@mvdhoek1
mvdhoek1 force-pushed the feat/filter-zaken-on-zaaktypen branch 2 times, most recently from 63cd85a to 0f5e8aa Compare September 22, 2026 08:58
@mvdhoek1
mvdhoek1 force-pushed the feat/filter-zaken-on-zaaktypen branch from 0f5e8aa to 69ff3c4 Compare September 22, 2026 09:59
@mvdhoek1
mvdhoek1 merged commit ab93136 into main Sep 22, 2026
1 check passed
@mvdhoek1
mvdhoek1 deleted the feat/filter-zaken-on-zaaktypen branch September 22, 2026 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants