Repository navigation
[Access] Scoped Authorization Grant - #48
Merged
Merged
Conversation
ericnordelo
requested review from
0xNeshi,
igingu and
pepebndc
as code owners
September 9, 2026 11:25
pepebndc
approved these changes
Sep 15, 2026
pepebndc
reviewed
Sep 23, 2026
pepebndc
left a comment
pepebndc
left a comment
Collaborator
There was a problem hiding this comment.
An independent two-model review (Claude and Codex) of this PR at a49fd3f. Neither reviewer found a critical, high, or medium defect. The guard enforces authority, grantee, scope, revocation, ledger-time bounds, and contract-ID binding, and both examples use it correctly.
The inline comments cover the three low findings and the missing tests. #50 targets this branch and applies those, plus nine info-level documentation fixes, one commit per finding.
igingu
reviewed
Sep 23, 2026
igingu
left a comment
igingu
left a comment
Collaborator
There was a problem hiding this comment.
@ericnordelo nicely done, I like the simplicity! I left three ideas.
…feat/scoped-authorization-grant
igingu
approved these changes
Sep 29, 2026
0xNeshi
reviewed
Sep 29, 2026
0xNeshi
approved these changes
Sep 29, 2026
Collaborator
There was a problem hiding this comment.
Good job
Asked for #48 (comment), but approving in advance
igingu
reviewed
Sep 29, 2026
igingu
approved these changes
Sep 30, 2026
igingu
left a comment
igingu
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for the great work!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds ScopedAuthorizationGrantV1 as a reusable access-control component. Applications can issue revocable, time-bounded grants and validate the caller, authority, and resource scope before executing protected choices. Includes optional contract-ID binding, structured errors, and usage events.
Includes licensing and treasury integration examples, isolated tests, and integration documentation. The treasury example demonstrates role-based access control built on the generic grant model. Removes the old AccessControl and Ownable experiments.