Repository navigation
Timelock: direct-archive caveat, ARCHITECTURE.md cleanup - #54
Merged
Merged
Conversation
…t skips the lifecycle functions does not compile
pepebndc
approved these changes
Oct 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is just a partial review of #47 .
Changes
Cancellers do not bound direct archives
packages/security/api-timelock-v1/README.mdnow states thatcancellersdoes not limit who can remove an operation, because its signatories can always callArchivedirectly. It also says to use the timelock's full signatory set if no single signatory may remove an operation alone.Why: Daml always gives signatories an
Archivechoice, so integrators need to know about it and size the signatory set themselves.ARCHITECTURE.mdTransferFactory_Transferexample and a pointer toChecked.Why: the pattern applies to any component with interfaces, not only Timelock.
README.mdcontent: package contents, lifecycle authority, and the three-contract integration layout.Why:
ARCHITECTURE.mdholds design rationale. Usage and behavior belong in the packageREADME.mdfiles.Pausableandpauseas code.Why: the migration paragraph applies to any contract state, so the component-specific examples were not needed.