feat(carriers): start new careers at the hiring carrier's terminal - #255
Merged
Merged
Conversation
Orinks
force-pushed
the
wip/carrier-s2-start-flow
branch
from
September 26, 2026 20:00
35bfbc2 to
da92dba
Compare
The new-career flow is region, then home city, then carrier. The picker
lists only cities where is_offerable_home_city holds and a start option
offers a carrier that hires there, so Alaska, BC, and Yukon stay out. The
carrier list shows only carriers that hire in the picked city: nationals
across the lower 48, Prairie Link only within 250 air miles of its
terminals. Each row says where the truck starts.
The truck starts at that carrier's nearest terminal: current_city is
home_terminal_city and parked_facility is "{Carrier} {City} terminal".
The first-day briefing says orientation and truck assignment happen there.
A start never falls back to another carrier's far-away terminal. A career
reset restarts from the old home terminal city.
Slice 2 ROADMAP rows are checked off and the CHANGELOG says the picker
enforces the home-base rule.
When the carrier terminal city differs from the picked home city, the
company-driver first-day briefing adds: "The carrier covered your travel
from {Home city} and a hotel for orientation." Owner-operators and hires
whose terminal is in their home city do not hear it.
The picked home city is now saved as home_city, so the driver's home is
kept apart from the terminal city; a career reset restarts from it. The
profile integrity export fixture gains the field, and the integrity
blocker row lists it. A ROADMAP row for the carrier home-time slice keeps
the terminal city from ever silently becoming the driver's home.
Orinks
changed the base branch from
wip/carrier-s1-home-fix
to
feat/career-2.0
September 26, 2026 20:24
Orinks
force-pushed
the
wip/carrier-s2-start-flow
branch
from
September 26, 2026 20:24
da92dba to
e8ddac3
Compare
A reset starts over from the saved home city. A career from before the home city was recorded seeds the reset from its old terminal city, and that terminal city was then saved as the driver's home; it now stays blank. Tests cover both reset paths.
The home city help and the carrier list announcement counted start rows, so the owner-operator start (leased to a listed carrier) read as an extra carrier: Milwaukee now says 3 carriers hire there and Wichita 4. The first-day briefing uses the shared service-area phrase, and a test comment is re-indented. [skip changelog]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Carrier slice 2: the new-career start flow uses carrier-owned home terminals.
#253 has merged; this PR targets
feat/career-2.0and is rebased on its tipa38930f8.Changes
is_offerable_home_cityis true and a start option offers a carrier that hires there. Alaska, British Columbia, and Yukon stay blocked until an Alaska regional exists. A region with no offerable city is left out.current_city = home_terminal_city,parked_facility = "{Carrier} {City} terminal"). A Milwaukee pick with Northstar starts in Chicago at Northstar Freight Lines Chicago terminal. A start never falls back to another carrier's far-away terminal.change_carrier).home_city(the integrity export fixture and blocker row include it), and a ROADMAP row for the carrier home-time slice keeps the terminal city from silently becoming the driver's home.Tests
test_a_start_puts_the_truck_at_the_hiring_carriers_terminal,test_a_regional_start_out_of_range_never_takes_a_far_away_home,test_start_options_for_a_city_are_only_carriers_that_hire_theretest_home_picker_offers_only_cities_where_a_carrier_hires(Healy, Anchorage, and Whitehorse excluded; Chicago and Milwaukee included),test_milwaukee_pick_with_northstar_starts_at_the_chicago_terminal,test_carrier_list_shows_only_carriers_that_hire_in_the_home_city(Wichita/Hutchinson vs Boston),test_prairie_link_row_near_wichita_starts_at_the_wichita_terminal,test_carrier_rows_say_where_the_truck_starts,test_owner_operator_briefing_names_the_lease_terminal,test_every_offered_home_city_has_a_carrier_that_hires_there,test_a_hire_away_from_the_terminal_hears_the_carrier_covered_travel,test_a_hire_in_the_terminal_city_hears_no_travel_line,test_an_owner_operator_hears_no_travel_line