Skip to content

fix: truthful felony-stop, freight market, and pickup wording - #256

Open
Orinks wants to merge 14 commits into
feat/career-2.0from
wip/carrier-location-wording
Open

Orinks wants to merge 14 commits into
feat/career-2.0from
wip/carrier-location-wording

Conversation

@Orinks

@Orinks Orinks commented Sep 26, 2026

Copy link
Copy Markdown
Owner

Follow-up wording fixes after #253.

  • fix(roadside): the felony stop no longer names the home terminal. The truck stays where it was stopped, so the summary now ends "You are released." and the intro help says "Enter or Escape continues." The row help says "Continue from where the truck is parked." New test: states_driving_enforcement_record::test_a_felony_stop_away_from_home_never_names_the_home_terminal.
  • fix(jobs): new shared ff_core::speech_text::the_city keeps a city name that already starts with "The". It is used by facility_text and facility_offer_text ("The Dalles metro freight market") and by home_base::city_service_area. Tests: speech_text::tests::test_the_city_keeps_a_name_that_carries_its_own_article, models::jobs::tests::test_metro_market_text_does_not_double_the_dalles_article.
  • docs(manual): the pickup deadhead starts from wherever the truck is parked, not from the terminal.

CHANGELOG bullets are added for the two user-facing fixes.

The felony stop said it released the driver back to the home terminal and that Enter continued from the terminal, but the truck stays where it was. It now says 'You are released.' and 'Enter or Escape continues.', with a test that a stop away from home never names the home terminal.
Add speech_text::the_city, which keeps a city name that already starts with 'The', and use it for the metro freight market lines and city_service_area.
@Orinks
Orinks force-pushed the wip/carrier-location-wording branch from cc69343 to b0551be Compare September 26, 2026 21:50
A felony stop left current_city and parked_facility where the run started, so the hub named a place the truck never went. The truck is now towed to the nearest travel_center or truck_parking facility within 100 air miles, or the nearest real facility when no lot is that close, and the summary names that place. The load line now follows who owns the run: the carrier recovers a company or leased load, and an own-authority load is left to the shipper.
Police arrest tows go to a rotation wrecker's impound yard, never a truck stop, shipper or carrier yard. The felony stop now sets current_city to the stop city (nearest world city on the road's side of any state line or border, or the leg city without road coordinates) and parked_facility to the impound_lot sentinel, which is not a world pin. The hub reads it as an impound lot in that city ahead of the carrier terminal and every pin. The nearest-lot tow helper and its radius are gone.
…r-location-wording

# Conflicts:
#	crates/ff-core/src/models/jobs/tests.rs
The hub said 'Parked at an impound lot in the Buffalo service area', which reads as a turnpike travel plaza. For the impound case only it now says 'Parked at an impound lot in Buffalo, New York.' (The Dalles: 'in The Dalles, Oregon.'), matching the tow summary. Every other hub line is unchanged.

[skip changelog]
The impound status cleared only at the pickup gate or on completion, so a deadhead, reposition or bobtail abandoned after a felony tow came back 'parked at an impound lot'. launch_driving, which every deadhead, reposition, bobtail and loaded leg starts through, now clears it. The dev playtest staging line uses the_city so it no longer says 'the The Dalles'.
…r-location-wording

# Conflicts:
#	crates/freight-fate/src/states/city/terminal.rs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant