Alpenglow, VM, Performance Enhancements and bug fixes

.github/workflows/go_build.yml

@@ -17,3 +17,33 @@ jobs:
 
       - name: Build
         run: go build -v ./cmd/mithril
+
+  regression-tests:
+    runs-on: ubuntu-latest
+    timeout-minutes: 20
+    permissions:
+      contents: read
+    env:
+      GOMAXPROCS: "2"
+    steps:
+      - uses: actions/checkout@v3
+
+      - name: Setup Go
+        uses: actions/setup-go@v4
+        with:
+          go-version: 1.26.4
+
+      - name: Voting, checkpoint, streaming and scheduler race regressions
+        # Run the complete affected package suites, including subprocess crash
+        # recovery and cancellation tests.
+        run: >-
+          go test -race -p 2 -count=1
+          ./pkg/alpenglow ./pkg/consensus ./pkg/replay ./pkg/rewards
+          ./pkg/turbine ./pkg/sigverify ./pkg/blockprod/...
+          ./cmd/mithril/node ./cmd/mithril/configcmd
+
+      - name: Interpreter differential and memory race regressions
+        run: go test -race -count=1 ./pkg/sbpf/...
+
+      - name: Sealevel interpreter, syscall and vote ownership regressions
+        run: go test -race -count=1 ./pkg/sealevel

cmd/mithril/configcmd/configcmd.go

@@ -158,6 +158,9 @@ authorized_voter_keypair = ""      # BLS derivation signer (empty defaults to id
 authorized_withdrawer_keypair = "" # Authorized withdrawer keypair path (diagnostics only)
 tpu_quic_bind_addr = "0.0.0.0:8004"
 advertised_ip = ""                 # Required only in validator mode; public IP advertised for TPU QUIC
+wait_to_vote_slot = 0             # Minimum slot for new votes; does not bypass recovery checks
+tpu_max_buffered_transactions = 0 # 0 = 131,072 buffered transactions
+block_completion_reserve_ms = 0   # 0 = 75ms local completion/broadcast reserve
 tpu_sigverify_workers = 0          # 0 = GOMAXPROCS
 
 [consensus]
@@ -175,6 +178,9 @@ authorized_voter_keypair = ""                               # Empty defaults to
 authorized_withdrawer_keypair = ""
 tpu_quic_bind_addr = "0.0.0.0:8004"
 advertised_ip = "" # REQUIRED: public IP advertised for TPU QUIC
+wait_to_vote_slot = 0             # Minimum slot for new votes; does not bypass recovery checks
+tpu_max_buffered_transactions = 0 # 0 = 131,072 buffered transactions
+block_completion_reserve_ms = 0   # 0 = 75ms local completion/broadcast reserve
 tpu_sigverify_workers = 0
 
 [consensus]
@@ -261,7 +267,12 @@ max_rps = 8               # Verifier's own RPC budget (never shares the block-fe
 # ── Replay tuning ────────────────────────────────────────────────────────
 [tuning]
 txpar = 24                # Validator auto-defaults to 2x CPU cores only when unset; explicit 0 = sequential
-sigverify_backend = "auto" # auto|r51|generic|stdlib; stdlib uses Go's crypto/ed25519 impl after strict checks.
+
+[sigverify]
+backend = "auto"          # auto|r51|generic|stdlib
+workers = 0               # 0 = min(2, GOMAXPROCS); explicit value overrides the shared transaction pool
+batch_target = 8          # 4 or 8 signature lanes; available work runs immediately
+disable_shred_overlap = false # Diagnostic fallback: verify after complete block assembly
 
 # ── Mithril's RPC server ─────────────────────────────────────────────────
 [rpc]

cmd/mithril/configcmd/configcmd_test.go

@@ -0,0 +1,28 @@
+package configcmd
+
+import (
+	"strings"
+	"testing"
+
+	"github.com/spf13/viper"
+	"github.com/stretchr/testify/require"
+)
+
+func TestStarterConfigSignatureVerification(t *testing.T) {
+	for _, validator := range []bool{false, true} {
+		v := viper.New()
+		v.SetConfigType("toml")
+		require.NoError(t, v.ReadConfig(strings.NewReader(generateStarterConfig(validator))))
+		for _, key := range []string{"validator.wait_to_vote_slot", "validator.tpu_max_buffered_transactions", "validator.block_completion_reserve_ms"} {
+			require.True(t, v.IsSet(key), key)
+			require.Zero(t, v.GetInt(key), key)
+		}
+		require.Equal(t, "auto", v.GetString("sigverify.backend"))
+		require.True(t, v.IsSet("sigverify.workers"))
+		require.Zero(t, v.GetInt("sigverify.workers"))
+		require.Equal(t, 8, v.GetInt("sigverify.batch_target"))
+		require.True(t, v.IsSet("sigverify.disable_shred_overlap"))
+		require.False(t, v.GetBool("sigverify.disable_shred_overlap"))
+		require.False(t, v.IsSet("tuning.sigverify_backend"))
+	}
+}

cmd/mithril/node/config_bool.go

@@ -0,0 +1,15 @@
+package node
+
+import "github.com/spf13/pflag"
+
+// resolveBoolOption preserves explicit false at either precedence level.
+// Defaults use DefValue, not a flag value potentially left by a previous run.
+func resolveBoolOption(flag *pflag.Flag, configured bool, configuredValue bool) bool {
+	if flag != nil && flag.Changed {
+		return flag.Value.String() == "true"
+	}
+	if configured {
+		return configuredValue
+	}
+	return flag != nil && flag.DefValue == "true"
+}

cmd/mithril/node/config_bool_test.go

@@ -0,0 +1,38 @@
+package node
+
+import (
+	"github.com/spf13/pflag"
+	"github.com/spf13/viper"
+	"github.com/stretchr/testify/require"
+	"strings"
+	"testing"
+)
+
+func TestResolveBoolOptionPrecedence(t *testing.T) {
+	for _, tc := range []struct {
+		name, toml, cli    string
+		defaultValue, want bool
+	}{
+		{"omitted true default", "", "", true, true},
+		{"omitted false default", "", "", false, false},
+		{"TOML false", "enabled=false", "", true, false},
+		{"TOML true", "enabled=true", "", false, true},
+		{"CLI false beats TOML true", "enabled=true", "false", true, false},
+		{"CLI true beats TOML false", "enabled=false", "true", false, true},
+		{"CLI false without TOML", "", "false", true, false},
+	} {
+		t.Run(tc.name, func(t *testing.T) {
+			v := viper.New()
+			v.SetConfigType("toml")
+			require.NoError(t, v.ReadConfig(strings.NewReader(tc.toml)))
+			flags := pflag.NewFlagSet("test", pflag.ContinueOnError)
+			flags.Bool("enabled", tc.defaultValue, "")
+			if tc.cli != "" {
+				require.NoError(t, flags.Set("enabled", tc.cli))
+			}
+			require.Equal(t, tc.want, resolveBoolOption(flags.Lookup("enabled"), v.IsSet("enabled"), v.GetBool("enabled")))
+		})
+	}
+	require.False(t, resolveBoolOption(nil, false, false))
+	require.True(t, resolveBoolOption(nil, true, true))
+}