Skip to content

fix(examples): replace removed categories.primary with taxonomy.primary - #542

Merged
Francisco Jiménez (jjcfrancisco) merged 2 commits into
mainfrom
jjcfrancisco-taxonomy-primary
Sep 25, 2026
Merged

Francisco Jiménez (jjcfrancisco) merged 2 commits into
mainfrom
jjcfrancisco-taxonomy-primary

Conversation

@jjcfrancisco

@jjcfrancisco Francisco Jiménez (jjcfrancisco) commented Sep 25, 2026 •

Copy link
Copy Markdown
Member

The 2026-09-23.0 release removed the categories field from places in favor of taxonomy, so the DuckDB smoke tests started failing on every PR. This swaps categories.primary for taxonomy.primary in the three example queries and the BigQuery snippet.

Tested against live data from 2026-09-23.0.

Closes #541.
Ref #539

@github-actions

github-actions Bot commented Sep 25, 2026 •

Copy link
Copy Markdown

✅MegaLinter analysis: Success

Descriptor Linter Files Fixed Errors Max errors Warnings Elapsed time
✅ JAVASCRIPT eslint 29 0 0 21.41s
✅ MARKDOWN markdownlint 285 0 0 0.51s
✅ SQL sqlfluff 79 0 0 6.23s

See detailed reports in MegaLinter artifacts

Your project could benefit from a custom flavor, which would allow you to run only the linters you need, and thus improve runtime performances. (Skip this info by defining FLAVOR_SUGGESTIONS: false)

  • Documentation: Custom Flavors
  • Command: npx mega-linter-runner@10.1.0 --custom-flavor-setup --custom-flavor-linters JAVASCRIPT_ES,MARKDOWN_MARKDOWNLINT,SQL_SQLFLUFF

MegaLinter is provided by OX Security
Show us your support by starring ⭐ the repository

@github-actions

github-actions Bot commented Sep 25, 2026 •

Copy link
Copy Markdown

🗺️ Overture Docs preview is live!

🌍 Preview site https://staging.overturemaps.org/docs/pr/542/index.html
🕐 Updated Sep 25, 2026 10:18 UTC
📝 Commit b4f54a6

Note

♻️ This preview updates automatically with each push to this PR.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

Remaining current-release Snowflake, Athena, and Synapse examples still reference the removed categories field.

Get a fresh assessment by requesting another Copilot review.

Review effort: Lite
Findings: 1 Medium severity

Open (1)
What changed in this PR

Updates Places examples from removed categories.primary to taxonomy.primary for the 2026-09-23.0 release.

Changes:

  • Updated three DuckDB queries.
  • Updated the BigQuery example.
File Description
src/​queries/​duckdb/​seattle_places_for_map.sql Uses taxonomy.primary.
src/​queries/​duckdb/​places_wawa.sql Uses taxonomy.primary.
src/​queries/​duckdb/​new_york_pizza.sql Filters via taxonomy.primary.
docs/​getting-data/​data-mirrors/​bigquery.mdx Updates the BigQuery example.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread docs/getting-data/data-mirrors/bigquery.mdx

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Categorically correct

@jjcfrancisco
Francisco Jiménez (jjcfrancisco) merged commit 3425d50 into main Sep 25, 2026
17 checks passed
@jjcfrancisco
Francisco Jiménez (jjcfrancisco) deleted the jjcfrancisco-taxonomy-primary branch September 25, 2026 10:57

This branch was successfully deployed

1 active deployment
staging — b4f54a63 Deployed Sep 25, 2026 by jjcfrancisco via Deploy #540
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update example queries to use taxonomy after categories removal in v2.0.0

3 participants