Victor Schappert (@vcschapp)'s review of #518 (superseded by #569) left two actionable inline comments that were deferred to a follow-up rather than folded into that PR. This tracks clearing them.
- Inline the
PathSegment alias (StructSegment | ArraySegment) at its use sites and drop it. FieldSegment already names the general Struct | Array | Map case, so PathSegment is a misleading middle name for a subset that excludes MapSegment.
- Expand the
Check docstring to relate expr (the single composed Column) and read_columns (its read-set), and to explain why they are carried separately.
No behavior change. The broader naming and map-generality threads from the same review are tracked separately in #570.
Victor Schappert (@vcschapp)'s review of #518 (superseded by #569) left two actionable inline comments that were deferred to a follow-up rather than folded into that PR. This tracks clearing them.
PathSegmentalias (StructSegment | ArraySegment) at its use sites and drop it.FieldSegmentalready names the generalStruct | Array | Mapcase, soPathSegmentis a misleading middle name for a subset that excludesMapSegment.Checkdocstring to relateexpr(the single composedColumn) andread_columns(its read-set), and to explain why they are carried separately.No behavior change. The broader naming and map-generality threads from the same review are tracked separately in #570.