Skip to content

Repository navigation

[BUG](ci) Generate PySpark expressions before building the published wheel #626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Victor Schappert (vcschapp) merged 2 commits into from
Aug 5, 2026
Merged

[BUG](ci) Generate PySpark expressions before building the published wheel #626

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
14c25f8
fix(ci): generate pyspark expressions before building the published w…
sethfitz Jul 31, 2026
1609375
chore(pyspark): add changelog fragment for wheel packaging fix
sethfitz Aug 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions .github/workflows/publish-python-packages.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,16 @@ jobs:
id: get-code-artifact-params
uses: ./.github/actions/code-artifact

# overture-schema-pyspark ships generated validation expressions that are
# not committed to git -- they are regenerated on demand from the Pydantic
# models. `uv build` packages whatever is on disk under the module root, so
# the tree must be generated here before the build, or the published wheel
# ships without its `expressions/generated/` modules and validate_model()
# discovers nothing to run.
- name: Generate PySpark expressions before build
if: matrix.package == 'overture-schema-pyspark'
run: make generate-pyspark

- name: Publish package ${{ matrix.package }} version ${{ matrix.after }} to PyPI
env:
CA_TOKEN: ${{ steps.get-code-artifact-params.outputs.token }}
Expand All @@ -94,6 +104,14 @@ jobs:
echo " Wheel file [$wheel] not found. Aborting!"
exit 1
fi
# Guard against a silently empty wheel: if the generate step above ever
# regresses, overture-schema-pyspark would publish with no validation
# expressions. Fail loudly instead of shipping a hollow package.
if [ "$PACKAGE" = "overture-schema-pyspark" ] && \
! unzip -l "$wheel" | grep -q 'expressions/generated/.*\.py'; then
echo " Wheel [$wheel] has no generated expressions -- codegen did not run. Aborting!"
exit 1
fi
tarball="dist/${PACKAGE//-/_}-${AFTER}.tar.gz"
if [ ! -f "$tarball" ]; then
echo " Source tarball file [$tarball] not found. Aborting!"
Expand Down
1 change: 1 addition & 0 deletions packages/overture-schema-pyspark/changelog.d/625.bugfix.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fixed published wheels and sdists shipping without the generated validation expressions, which left an installed `validate_model()` unable to discover any models.