Skip to content

Repository navigation

[ENHANCEMENT](transportation) Make segment connectors required #692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Victor Schappert (vcschapp) merged 1 commit into from
Aug 26, 2026
Merged

[ENHANCEMENT](transportation) Make segment connectors required #692

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions counterexamples/common/names/names-invalid-language.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,11 @@ properties:
version: 1
subtype: road
class: primary
connectors:
- connector_id: fooConnector
at: 0
- connector_id: barConnector
at: 1
names:
primary: Foo
common:
Expand Down
5 changes: 5 additions & 0 deletions counterexamples/common/names/names-invalid-variant.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,11 @@ properties:
version: 1
subtype: road
class: primary
connectors:
- connector_id: fooConnector
at: 0
- connector_id: barConnector
at: 1
names:
primary: Bar
rules:
Expand Down
4 changes: 4 additions & 0 deletions counterexamples/transportation/segment/bad-geometry-type.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,10 @@
"theme": "transportation",
"type": "segment",
"subtype": "water",
"connectors": [
{ "connector_id": "fooConnector", "at": 0 },
{ "connector_id": "barConnector", "at": 1 }
],
"version": 15
}
}
4 changes: 4 additions & 0 deletions counterexamples/transportation/segment/bad-lr-width-missing-items.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,10 @@
"version": 26,
"subtype": "road",
"class": "primary",
"connectors": [
{ "connector_id": "fooConnector", "at": 0 },
{ "connector_id": "barConnector", "at": 1 }
],
"width_rules": [],
"ext_expected_errors": [
"minItems: got 0, want 1"
Expand Down
4 changes: 4 additions & 0 deletions counterexamples/transportation/segment/bad-lr-width.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,10 @@
"version": 26,
"subtype": "road",
"class": "primary",
"connectors": [
{ "connector_id": "fooConnector", "at": 0 },
{ "connector_id": "barConnector", "at": 1 }
],
"width_rules": [
{
"between" : [0, 0.5],
Expand Down
6 changes: 5 additions & 1 deletion counterexamples/transportation/segment/missing-subtype.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,10 @@
],
"theme": "transportation",
"type": "segment",
"version": 26
"version": 26,
"connectors": [
{ "connector_id": "fooConnector", "at": 0 },
{ "connector_id": "barConnector", "at": 1 }
]
}
}
6 changes: 5 additions & 1 deletion counterexamples/transportation/segment/missing-version.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,10 @@
],
"theme": "transportation",
"type": "segment",
"subtype": "water"
"subtype": "water",
"connectors": [
{ "connector_id": "fooConnector", "at": 0 },
{ "connector_id": "barConnector", "at": 1 }
]
}
}
5 changes: 5 additions & 0 deletions counterexamples/transportation/segment/property-subtype-mismatch.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,11 @@ properties:
version: 1
# Segment of subtype rail has a road flag (should be disallowed)
subtype: rail
connectors:
- connector_id: fooConnector
at: 0
- connector_id: barConnector
at: 1
road_flags:
- values: [is_indoor]
ext_expected_errors:
Expand Down
6 changes: 5 additions & 1 deletion counterexamples/transportation/segment/rail/bad-rail-class.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,10 @@
"type": "segment",
"version": 18,
"subtype": "rail",
"class": "foo"
"class": "foo",
"connectors": [
{ "connector_id": "fooConnector", "at": 0 },
{ "connector_id": "barConnector", "at": 1 }
]
}
}
4 changes: 4 additions & 0 deletions counterexamples/transportation/segment/rail/bad-rail-flags-duplicate-flag.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,10 @@
"version": 19,
"subtype": "rail",
"class": "primary",
"connectors": [
{ "connector_id": "fooConnector", "at": 0 },
{ "connector_id": "barConnector", "at": 1 }
],
"rail_flags": [
{
"values": ["is_freight", "is_freight"]
Expand Down
4 changes: 4 additions & 0 deletions counterexamples/transportation/segment/rail/bad-rail-flags-invalid-flag.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,10 @@
"version": 20,
"subtype": "rail",
"class": "primary",
"connectors": [
{ "connector_id": "fooConnector", "at": 0 },
{ "connector_id": "barConnector", "at": 1 }
],
"rail_flags": [
{
"values": ["foo"]
Expand Down
6 changes: 5 additions & 1 deletion counterexamples/transportation/segment/road/bad-road-class.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,10 @@
"type": "segment",
"version": 18,
"subtype": "road",
"class": "foo"
"class": "foo",
"connectors": [
{ "connector_id": "fooConnector", "at": 0 },
{ "connector_id": "barConnector", "at": 1 }
]
}
}
4 changes: 4 additions & 0 deletions counterexamples/transportation/segment/road/bad-road-flags-duplicate-flag.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,10 @@
"version": 19,
"subtype": "road",
"class": "primary",
"connectors": [
{ "connector_id": "fooConnector", "at": 0 },
{ "connector_id": "barConnector", "at": 1 }
],
"road_flags": [
{
"values": ["is_tunnel", "is_tunnel"]
Expand Down
4 changes: 4 additions & 0 deletions counterexamples/transportation/segment/road/bad-road-flags-invalid-flag.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,10 @@
"version": 20,
"subtype": "road",
"class": "primary",
"connectors": [
{ "connector_id": "fooConnector", "at": 0 },
{ "connector_id": "barConnector", "at": 1 }
],
"road_flags": [
{
"values": ["foo"]
Expand Down
4 changes: 4 additions & 0 deletions counterexamples/transportation/segment/road/bad-road-flags-invalid-is_private-flag.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,10 @@
"version": 20,
"subtype": "road",
"class": "primary",
"connectors": [
{ "connector_id": "fooConnector", "at": 0 },
{ "connector_id": "barConnector", "at": 1 }
],
"road_flags": [
{
"values": ["is_private"]
Expand Down
4 changes: 4 additions & 0 deletions counterexamples/transportation/segment/road/bad-road-flags-invalid-string-value.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,10 @@
"version": 20,
"subtype": "road",
"class": "primary",
"connectors": [
{ "connector_id": "fooConnector", "at": 0 },
{ "connector_id": "barConnector", "at": 1 }
],
"road_flags": ["is_tunnel"]
}
}
4 changes: 4 additions & 0 deletions counterexamples/transportation/segment/road/bad-road-invalid-temporal-scoping.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,10 @@
"version": 20,
"subtype": "road",
"class": "primary",
"connectors": [
{ "connector_id": "fooConnector", "at": 0 },
{ "connector_id": "barConnector", "at": 1 }
],
"road_flags": [
{
"values": ["is_bridge"]
Expand Down
4 changes: 4 additions & 0 deletions counterexamples/transportation/segment/road/bad-road-surface-invalid-rule-value.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,10 @@
"version": 23,
"subtype": "road",
"class": "primary",
"connectors": [
{ "connector_id": "fooConnector", "at": 0 },
{ "connector_id": "barConnector", "at": 1 }
],
"road_surface": [
{
"value": "hot mess"
Expand Down
5 changes: 5 additions & 0 deletions ...es/transportation/segment/road/restrictions/access/bad-access-unsupported-properties.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,11 @@ properties:
type: segment
subtype: road
class: tertiary
connectors:
- connector_id: fooConnector
at: 0
- connector_id: barConnector
at: 1
version: 1
access_restrictions:
- foo: bar
Expand Down
5 changes: 5 additions & 0 deletions ...ansportation/segment/road/restrictions/prohibited_transitions/unsupported-properties.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,11 @@ properties:
type: segment
subtype: road
class: residential
connectors:
- connector_id: fooConnector
at: 0
- connector_id: barConnector
at: 1
version: 1
prohibited_transitions:
- sequence:
Expand Down
4 changes: 4 additions & 0 deletions ...es/transportation/segment/road/restrictions/speed_limits/bad-speed-limits-empty-rule.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,10 @@
"version": 26,
"subtype": "road",
"class": "primary",
"connectors": [
{ "connector_id": "fooConnector", "at": 0 },
{ "connector_id": "barConnector", "at": 1 }
],
"speed_limits": [
{}
],
Expand Down
4 changes: 4 additions & 0 deletions .../transportation/segment/road/restrictions/speed_limits/bad-speed-limits-invalid-type.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,10 @@
"version": 0,
"subtype": "road",
"class": "primary",
"connectors": [
{ "connector_id": "fooConnector", "at": 0 },
{ "connector_id": "barConnector", "at": 1 }
],
"speed_limits": {},
"ext_expected_errors": [
"'/properties/speed_limits' [S#/$defs/propertyContainers/speedLimitsContainer/type]: got object, want array"
Expand Down
5 changes: 5 additions & 0 deletions examples/common/names/names-lexically-valid-language-tag.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,11 @@ properties:
version: 1
subtype: road
class: primary
connectors:
- connector_id: fooConnector
at: 0
- connector_id: barConnector
at: 1
names:
primary: foo
common:
Expand Down
5 changes: 5 additions & 0 deletions examples/common/timestamp/timestamp-leap-second.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,4 +9,9 @@ properties:
type: segment
subtype: road
class: primary
connectors:
- connector_id: fooConnector
at: 0
- connector_id: barConnector
at: 1
version: 1
5 changes: 5 additions & 0 deletions examples/transportation/docusaurus/access-restriction-01-blanket.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,5 +12,10 @@ properties:
version: 1
subtype: road
class: residential
connectors:
- connector_id: fooConnector
at: 0
- connector_id: barConnector
at: 1
access_restrictions:
- access_type: denied
5 changes: 5 additions & 0 deletions examples/transportation/docusaurus/access-restriction-02-private-with-deliveries.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,11 @@ properties:
version: 1
subtype: road
class: residential
connectors:
- connector_id: fooConnector
at: 0
- connector_id: barConnector
at: 1
access_restrictions:
- access_type: denied
- access_type: allowed
Expand Down
5 changes: 5 additions & 0 deletions ...ples/transportation/docusaurus/access-restriction-03-motor-vehicles-destination-only.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,11 @@ properties:
version: 1
subtype: road
class: residential
connectors:
- connector_id: fooConnector
at: 0
- connector_id: barConnector
at: 1
access_restrictions:
- access_type: denied
when: { mode: [motor_vehicle] }
Expand Down
5 changes: 5 additions & 0 deletions examples/transportation/docusaurus/access-restriction-04-axle-limit.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,11 @@ properties:
version: 1
subtype: road
class: motorway
connectors:
- connector_id: fooConnector
at: 0
- connector_id: barConnector
at: 1
access_restrictions:
- access_type: denied
when:
Expand Down
5 changes: 5 additions & 0 deletions examples/transportation/docusaurus/geometric-scoping.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,11 @@ properties:
version: 1
subtype: road
class: primary
connectors:
- connector_id: fooConnector
at: 0
- connector_id: barConnector
at: 1
speed_limits:
- between: [0, 0.15]
max_speed:
Expand Down
5 changes: 5 additions & 0 deletions examples/transportation/docusaurus/speed-limits-01-simple.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,11 @@ properties:
version: 1
subtype: road
class: residential
connectors:
- connector_id: fooConnector
at: 0
- connector_id: barConnector
at: 1
speed_limits:
- max_speed:
value: 30
Expand Down
5 changes: 5 additions & 0 deletions examples/transportation/docusaurus/speed-limits-02-directional.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,11 @@ properties:
version: 2
subtype: road
class: secondary
connectors:
- connector_id: fooConnector
at: 0
- connector_id: barConnector
at: 1
speed_limits:
- max_speed: {value: 70, unit: "mph"}
- when:
Expand Down
5 changes: 5 additions & 0 deletions examples/transportation/docusaurus/speed-limits-03-variable-max.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,11 @@ properties:
version: 1
subtype: road
class: motorway
connectors:
- connector_id: fooConnector
at: 0
- connector_id: barConnector
at: 1
speed_limits:
- max_speed:
value: 100
Expand Down
5 changes: 5 additions & 0 deletions examples/transportation/docusaurus/subjective-heading-scoping.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,11 @@ properties:
version: 2
subtype: road
class: primary
connectors:
- connector_id: fooConnector
at: 0
- connector_id: barConnector
at: 1
access_restrictions:
- access_type: denied
when: { heading: backward }
Expand Down
5 changes: 5 additions & 0 deletions examples/transportation/docusaurus/subjective-status-scoping.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,11 @@ properties:
version: 1
subtype: road
class: tertiary
connectors:
- connector_id: fooConnector
at: 0
- connector_id: barConnector
at: 1
access_restrictions:
- access_type: denied
- access_type: allowed
Expand Down
Loading
Loading