Repository navigation
[BUG](ci) Always run vnext-compat check with a noop + rollup path - #705
Merged
Victor Schappert (vcschapp) merged 2 commits intoAug 27, 2026
Merged
Conversation
Trigger fired only on PRs targeting main, so a PR based on any other branch (e.g. #434, based on vnext) never got a run. Marking this check required would hang those PRs forever. Drop the branches:[main] restriction so the workflow always fires. Guard compat-check to only do real work for PRs targeting main (excluding the vnext release PR itself); add a noop job for everything else. Both feed a vnext-status rollup via lowlydba/are-we-good, so there's one consistently-named check to eventually require. Fixes #704 Signed-off-by: John McCall <john@overturemaps.org>
John McCall (lowlydba)
marked this pull request as ready for review
August 27, 2026 15:33
John McCall (lowlydba)
temporarily deployed
to
staging
August 27, 2026 15:33 — with 
GitHub Actions
Inactive
GitHub Actions
Inactive
🗺️ Schema reference docs preview is live!
Note ♻️ This preview updates automatically with each push to this PR. |
John McCall (lowlydba)
requested review from
Connie Sun (connieksun),
Seth Fitzsimmons (sethfitz) and
Victor Schappert (vcschapp)
August 27, 2026 15:34
John McCall (lowlydba)
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the vnext-compat GitHub Actions workflow so it triggers for PRs targeting any base branch, while still only performing the actual vnext compatibility work for PRs targeting main. This enables a single consistently-named rollup check to be required later without leaving non-main PRs permanently pending.
Changes:
- Remove the
pull_request.branches: [main]restriction so the workflow always fires on PR events. - Gate the real
compat-checkjob to only run for PRs targetingmain(and not for thevnextrelease PR). - Add a
nooppath plus avnext-statusrollup job to ensure there is always one stable check name to require.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
…ions Match the pin already used by check-python-code.yaml and require-changelog-fragment.yaml, and give the rollup job an explicit empty permissions block since it only reads the needs context. Signed-off-by: John McCall <john@overturemaps.org>
Connie Sun (connieksun)
approved these changes
Aug 27, 2026
Victor Schappert (vcschapp)
approved these changes
Aug 27, 2026
Victor Schappert (vcschapp)
deleted the
lowlydba-vnext-check-noop-rollup
branch
August 27, 2026 17:55
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
vnext-compat.yamltriggers onpull_request: branches: [main]only. A PR based on any other branch (e.g. #434, based onvnext) never gets a run. Marking this check required (which it is) would hang those PRs pending forever.Drops the
branches: [main]restriction so the workflow always fires.compat-checkis now gated to only do real work for PRs targetingmain(excluding the vnext release PR itself,head_ref == 'vnext'); a newnoopjob covers everything else. Both feed avnext-statusrollup job via lowlydba/are-we-good, so there's one consistently-named check to eventually add to branch protection.Fixes #704
Testing
Validated the YAML parses and reasoned through the three cases by hand (no CI run yet since this only matters once a PR is opened against this branch):
vnext(like [ENHANCEMENT] Remove old categories in favor of the new taxonomy field [Target: September release] #434):compat-checkskipped,noopruns,vnext-statuspasses.main:compat-checkruns for real,noopskipped,vnext-statusreflectscompat-check's result.vnext→mainrelease PR:compat-checkskipped (self-referential),noopruns,vnext-statuspasses.