Repository navigation
[BUG](ci) Open uv-lock-refresh PRs as overture-pull-requester - #732
Conversation
The default GITHUB_TOKEN can't clear the required 'OMF PR Check' linked-issue check, so uv-lock-refresh PRs (which have no issue to link) got stuck once #729 fixed the PR-creation permission. Use the overture-pull-requester app -- already used for the vnext rebase -- which has a bypass for that check. Fixes #731 Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Signed-off-by: John McCall <john@overturemaps.org>
🗺️ Schema reference docs preview is live!
Note ♻️ This preview updates automatically with each push to this PR. |
There was a problem hiding this comment.
🟡 Changes recommended
The workflow still checks out with GITHUB_TOKEN (despite the stated fix for #731) and the new bot sign-off email is inconsistent with the repo’s existing overture-pull-requester identity usage.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
This PR updates the scheduled uv.lock refresh workflow to open/update its dependency-refresh PRs using the overture-pull-requester GitHub App token rather than the default GITHUB_TOKEN, so the resulting PR can bypass the required linked-issue check and trigger CI normally.
Changes:
- Add an
actions/create-github-app-tokenstep to mint an installation token foroverture-pull-requester. - Use that token for
peter-evans/create-pull-requestPR creation/updates. - Reduce job-level
GITHUB_TOKENpermissions and update the commit message sign-off identity.
File summaries
| File | Description |
|---|---|
.github/workflows/uv-lock-refresh.yml |
Switch PR creation for lockfile refresh to use the overture-pull-requester app token and adjust permissions/metadata accordingly. |
Review details
Suppressed comments (1)
.github/workflows/uv-lock-refresh.yml:45
- The issue/PR description for #731 calls out passing the GitHub App token to both
actions/checkoutandcreate-pull-request. Hereactions/checkoutstill uses the defaultGITHUB_TOKEN, which keeps the workflow partially dependent on job-levelpermissionsand can defeat the goal of running entirely under the app identity. Passing the app token to checkout (even withpersist-credentials: false) aligns with the stated fix and reduces coupling toGITHUB_TOKENbehavior.
- uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
with:
persist-credentials: false
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
…t.yaml Signed-off-by: John McCall <john@overturemaps.org>
What
uv-lock-refresh.ymlnow generates a token viaactions/create-github-app-token(theoverture-pull-requesterapp, same client-id/secret asrebase-vnext.yaml) and passes it tocreate-pull-request, instead of the implicitGITHUB_TOKEN.Why
#729 fixed the workflow's PR-creation permission, but the resulting PR (#730) is stuck: every check passes except the required "OMF PR Check" linked-issue check, since a scheduled lockfile refresh has no issue to link.
overture-pull-requesterhas a bypass for that check (it's how the vnext force-rebase clears it), and using an app token also means the PR triggers CI normally, unlike aGITHUB_TOKEN-authored one.Fixes #731
Testing
zizmor .github/workflows/uv-lock-refresh.yml— no findings.yaml.safe_load.workflow_dispatchtrigger); will confirm on the next run.